Serializing & Deserializing DateTime objects

[pipermatt]

The JsConfig object contains a flag called AssumeUtc. This flag causes the DateTimeSerializer to convert dates that are DateTimeKind.Unspecified on serialization to DateTimeKind.Utc using:

        if (JsConfig.AssumeUtc && dateTime.Kind == DateTimeKind.Unspecified)
        {
            dateTime = DateTime.SpecifyKind(dateTime, DateTimeKind.Utc);
        }

(lines 544-547 of NServiceKit.Text.Common.DateTimeSerializer)
However, deserialization ignores this flag and assumes that DateTimeKind.Unspecified should actually be DateTimeKind.Local.

Wouldn't it be preferable to have both serialization and deserialization honor this flag?

[pipermatt]

For now, we have fixed this internally by creating a custom version of DateTimeSerializer and then registering our custom version with...

        JsConfig<DateTime>.DeSerializeFn = CustomDateTimeSerializer.ParseShortestXsdDateTime;
        JsConfig<DateTime?>.DeSerializeFn = CustomDateTimeSerializer.ParseShortestNullableXsdDateTime;

...in our AppHost constructor.

This works, but I wanted to raise the question. I can submit a pull request with our change if you would like to review.

[vdaron]

Hi @pipermatt,

You'r right and if you can pull a request, I'll review it.

Thanks