warning on startup

[timsoftgit]

I get the following warning message on running wsdd2 -d

cannot read additional dns hostnames from testparm
cannot read netbios aliases from testparm

As there are no aliases or hostnames in smb.conf the messages are correct, although running as -d they should be logged to syslog rather than on stdout/err . I would like to suppress these information messages. I couldn't see an option to do so in the program parameters (only increasing the debug level). Is there a make/makefile option to suppress these messages which are likely to be shown on many samba setups, or a runtime way of suppressing them?

[timsoftgit]

if you change line 604 to read DEBUG(1, W, "cannot read %s from testparm", name); instead of
DEBUG(0, W, "cannot read %s from testparm", name);
then the messages are not printed. However, calling wsdd2 with -d -W -W or after this change should raise the debug level and show the message but it does not.

[whlsxl]

That's not a problem.
Usually, you don't set additional dns hostnames & netbios aliases in samba. wsdd2 will use netbios name as the share name.

[timsoftgit]

As you say, usually it is not in smb.conf.
My point was that there appears to be no way to surpress the "cannot load..." warning messages for these (normally unused) optional samba config parameters. wsdd2 should recognise that these are optional samba smb.conf parameters and not complain when they are not present.

[timsoftgit]

it appears to be because the get_smbparm macro/function has no concept of an optional samba parameter. Adding one to line 584 eg. changing static char *get_smbparm(const char *name, const char *_default) to static char *get_smbparm(const char *name, const char *_default, const int optional) and adding it to 603 if ((!fgets(buf, sizeof(buf), pp) || !buf[0] || buf[0] == '\n')&&!optional) (and adding the optional value each place that get_smbparm is called) would allow wsdd2 to not generate debug messages to stdio for optional samba parameters.

[timsoftgit]

the optional value could even be a value defaulting to 0, and set to non-zero if a command line option was set, to give the user the option to show or suppress warnings relating to optional samba parameters.