From 42724aaab9b895f694dde9290c29b5a11df1e99b Mon Sep 17 00:00:00 2001
From: Pierre Demailly <pierredemailly.pro@gmail.com>
Date: Tue, 21 Jan 2025 20:37:49 +0100
Subject: [PATCH] chore: activate lint for front codebase

---
 eslint.config.mjs                             | 21 ++++++++++++++++++-
 package.json                                  |  3 ++-
 public/components/navigation/navigation.js    |  2 +-
 public/components/package/header/header.js    |  8 +++----
 .../package/pannels/overview/overview.js      |  1 -
 .../package/pannels/warnings/code-fetcher.js  |  2 +-
 public/core/network-navigation.js             |  1 -
 7 files changed, 27 insertions(+), 11 deletions(-)

diff --git a/eslint.config.mjs b/eslint.config.mjs
index 96511cc8..81102eda 100644
--- a/eslint.config.mjs
+++ b/eslint.config.mjs
@@ -1,4 +1,5 @@
 import { ESLintConfig, globals } from "@openally/config.eslint";
+import jsdoc from "eslint-plugin-jsdoc";
 
 export default [
   ...ESLintConfig,
@@ -19,6 +20,24 @@ export default [
     }
   },
   {
-  ignores: ["**/node_modules/", "**/tmp/", "**/dist/", "**/coverage/", "**/fixtures/"]
+    files: ["public/**/*.js"],
+    plugins: {
+      jsdoc
+    },
+    rules: {
+      "jsdoc/no-undefined-types": ["warn", {
+        disableReporting: true,
+        markVariablesAsUsed: true
+      }]
+    }
+  },
+  {
+    ignores: [
+      "**/node_modules/",
+      "**/tmp/",
+      "**/dist/",
+      "**/coverage/",
+      "**/fixtures/"
+    ]
   }
 ];
diff --git a/package.json b/package.json
index 697904f7..cbd244c3 100644
--- a/package.json
+++ b/package.json
@@ -12,7 +12,7 @@
     "node": ">=20"
   },
   "scripts": {
-    "lint": "eslint bin src test workspaces",
+    "lint": "eslint bin src test workspaces public",
     "lint-fix": "npm run lint -- --fix",
     "prepublishOnly": "rimraf ./dist && npm run build && pkg-ok",
     "build": "node ./esbuild.config.js",
@@ -70,6 +70,7 @@
     "c8": "^10.1.2",
     "cross-env": "^7.0.3",
     "esbuild": "^0.24.0",
+    "eslint-plugin-jsdoc": "^50.6.2",
     "esmock": "^2.6.7",
     "glob": "^11.0.0",
     "http-server": "^14.1.1",
diff --git a/public/components/navigation/navigation.js b/public/components/navigation/navigation.js
index 4dead174..9cb3af95 100644
--- a/public/components/navigation/navigation.js
+++ b/public/components/navigation/navigation.js
@@ -75,7 +75,7 @@ export class ViewNavigation {
 
     const searchbar = document.getElementById("searchbar");
     if (searchbar) {
-      searchbar.style.display =  menuName === "network--view" ? "flex" : "none";
+      searchbar.style.display = menuName === "network--view" ? "flex" : "none";
     }
 
     this.activeMenu = selectedNav;
diff --git a/public/components/package/header/header.js b/public/components/package/header/header.js
index 2a032e5b..d4ee9e0d 100644
--- a/public/components/package/header/header.js
+++ b/public/components/package/header/header.js
@@ -24,7 +24,6 @@ export class PackageHeader {
       version: packageVersion,
       description: packageDescription = "",
       licenses,
-      repository,
       flags
     } = this.package.dependencyVersion;
 
@@ -68,7 +67,6 @@ export class PackageHeader {
     }
 
     // Links
-    const hasNoLicense = licenses.length === 0;
     const repositoryUrl = this.package.dependency.versions[packageVersion].links.repository;
     const repositoryUrlHostname = repositoryUrl ? new URL(repositoryUrl).hostname : null;
 
@@ -235,9 +233,9 @@ export class PackageHeader {
         htmlElement.addEventListener("click", () => {
           const { name } = flagsMap.get(icon);
 
-          wiki.header.setNewActiveView("flags");
-          wiki.navigation.flags.setNewActiveMenu(name);
-          wiki.open();
+          window.wiki.header.setNewActiveView("flags");
+          window.wiki.navigation.flags.setNewActiveMenu(name);
+          window.wiki.open();
         });
 
         fragment.appendChild(htmlElement);
diff --git a/public/components/package/pannels/overview/overview.js b/public/components/package/pannels/overview/overview.js
index 24982ce6..8977aecd 100644
--- a/public/components/package/pannels/overview/overview.js
+++ b/public/components/package/pannels/overview/overview.js
@@ -101,7 +101,6 @@ export class Overview {
       gitlab.pathname.includes(".git") ? -4 : gitlab.pathname.length
     );
 
-
     const {
       star_count,
       forks_count
diff --git a/public/components/package/pannels/warnings/code-fetcher.js b/public/components/package/pannels/warnings/code-fetcher.js
index eb207837..158266ba 100644
--- a/public/components/package/pannels/warnings/code-fetcher.js
+++ b/public/components/package/pannels/warnings/code-fetcher.js
@@ -116,7 +116,7 @@ export class CodeFetcher {
           if (value && line.includes(value)) {
             const indexStart = line.indexOf(value);
 
-            // eslint-disable-next-line max-len
+            // eslint-disable-next-line @stylistic/max-len
             return `${line.slice(0, indexStart)}<span class="relevant-line">${line.slice(indexStart, indexStart + endColumn)}</span>${line.slice(indexStart + endColumn)}`;
           }
           else if (startFrom + index === startLine) {
diff --git a/public/core/network-navigation.js b/public/core/network-navigation.js
index 1cb280ee..10f95cf2 100644
--- a/public/core/network-navigation.js
+++ b/public/core/network-navigation.js
@@ -82,7 +82,6 @@ export class NetworkNavigation {
     };
   }
 
-
   calculateAngle(position1, position2) {
     const dx = position2.x - position1.x;
     const dy = position2.y - position1.y;