From 7a6f8124c0ab64701a51bf2136e0bc88e72dbcb4 Mon Sep 17 00:00:00 2001 From: NickLocke Date: Thu, 4 Dec 2025 17:25:13 +0000 Subject: [PATCH 1/4] Enhanced messages --- app/Notifications/Banking/AuditResult.php | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/Notifications/Banking/AuditResult.php b/app/Notifications/Banking/AuditResult.php index b986c5ea..a5d87f81 100644 --- a/app/Notifications/Banking/AuditResult.php +++ b/app/Notifications/Banking/AuditResult.php @@ -190,22 +190,24 @@ public function toDiscord($notifiable) $embed = [ 'title' => 'Membership Audit Results', + 'description' => 'Each day, HMS produces an update of changes in the membership. This is a summary.', 'fields' => [ [ + // Adding text to the value rather than the name, because Discord always renders the name in bold and that would look horrible. 'name' => 'New Members', - 'value' => $approveCount, + 'value' => "We have seen a payment from $approveCount new members.", // Has to be double quotes for interpolation ], [ 'name' => 'Notified Members', - 'value' => $warnCount, + 'value' => "We have not seen a payment from $warnCount members recently, so they may soon have their membership revoked.", ], [ 'name' => 'Revoked Members', - 'value' => $revokeCount, + 'value' => "The last payment from $revokeCount members was too long ago, so their membership has been revoked.", ], [ 'name' => 'Reinstated Members', - 'value' => $reinstateCount, + 'value' => "$reinstateCount members have started paying again, so their membership has been reinstated.", ], ], ]; From 954dd7d970879e160476b87858ed123ccb5085e1 Mon Sep 17 00:00:00 2001 From: NickLocke Date: Thu, 4 Dec 2025 19:24:14 +0000 Subject: [PATCH 2/4] Changed from interpolation to concatenation. --- app/Notifications/Banking/AuditResult.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/Notifications/Banking/AuditResult.php b/app/Notifications/Banking/AuditResult.php index a5d87f81..0af384f4 100644 --- a/app/Notifications/Banking/AuditResult.php +++ b/app/Notifications/Banking/AuditResult.php @@ -195,19 +195,19 @@ public function toDiscord($notifiable) [ // Adding text to the value rather than the name, because Discord always renders the name in bold and that would look horrible. 'name' => 'New Members', - 'value' => "We have seen a payment from $approveCount new members.", // Has to be double quotes for interpolation + 'value' => 'We have seen a payment from ' . $approveCount . ' new members.', ], [ 'name' => 'Notified Members', - 'value' => "We have not seen a payment from $warnCount members recently, so they may soon have their membership revoked.", + 'value' => 'We have not seen a payment from ' . $warnCount . ' members recently, so they may soon have their membership revoked.', ], [ 'name' => 'Revoked Members', - 'value' => "The last payment from $revokeCount members was too long ago, so their membership has been revoked.", + 'value' => 'The last payment from ' . $revokeCount . ' members was too long ago, so their membership has been revoked.', ], [ 'name' => 'Reinstated Members', - 'value' => "$reinstateCount members have started paying again, so their membership has been reinstated.", + 'value' => $reinstateCount . ' members have started paying again, so their membership has been reinstated.', ], ], ]; From 7d6cddcad26a739f2c493aa5f649a189988400fe Mon Sep 17 00:00:00 2001 From: NickLocke Date: Thu, 4 Dec 2025 19:25:58 +0000 Subject: [PATCH 3/4] Clarified that the report is on weekdays only and removed the duplicated mention of HMS. --- app/Notifications/Banking/AuditResult.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Notifications/Banking/AuditResult.php b/app/Notifications/Banking/AuditResult.php index 0af384f4..33f107b9 100644 --- a/app/Notifications/Banking/AuditResult.php +++ b/app/Notifications/Banking/AuditResult.php @@ -190,7 +190,7 @@ public function toDiscord($notifiable) $embed = [ 'title' => 'Membership Audit Results', - 'description' => 'Each day, HMS produces an update of changes in the membership. This is a summary.', + 'description' => 'Produced each weekday, this is a sumamry of changes in membership.', 'fields' => [ [ // Adding text to the value rather than the name, because Discord always renders the name in bold and that would look horrible. From e303f088310002049da53bcb713fa8279bd2f61c Mon Sep 17 00:00:00 2001 From: NickLocke Date: Thu, 4 Dec 2025 20:19:53 +0000 Subject: [PATCH 4/4] Fixed issue with trailing space after comma. --- app/Notifications/Banking/AuditResult.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Notifications/Banking/AuditResult.php b/app/Notifications/Banking/AuditResult.php index 33f107b9..68bc3a36 100644 --- a/app/Notifications/Banking/AuditResult.php +++ b/app/Notifications/Banking/AuditResult.php @@ -195,7 +195,7 @@ public function toDiscord($notifiable) [ // Adding text to the value rather than the name, because Discord always renders the name in bold and that would look horrible. 'name' => 'New Members', - 'value' => 'We have seen a payment from ' . $approveCount . ' new members.', + 'value' => 'We have seen a payment from ' . $approveCount . ' new members.', ], [ 'name' => 'Notified Members',