-
Notifications
You must be signed in to change notification settings - Fork 32
Open
Description
Hey!
I've been trying to work with the get_many getters lately and they're essentially useless IMO because:
- They take a single argument and perform a
=test on it in the SQL query - They will return a single row in cases you're searching something like a UNIQUE index.
Meaning that you will have to resort to manual SQL queries if you're doing something as trivial as looking multiple records by a batched id/unique key.
I suggest changing the query in get_many to use a IN() statement instead of = and accepting a slice of arguments instead of a single one as it would semantically work as well.
But of course, as it'd be a breaking change, I'm triggering a discussion here.
I can take care of the implementation.
nicoulaj
Metadata
Metadata
Assignees
Labels
No labels