graph_base is broken due to the recent update of the graphql-server in pip

[ivs-cetmix]

Module

graphql_base

Describe the bug

The graphql_base doesn't have any specific library version pinned in the external pyhon dependencies.  Recently graphql-server package was updated to the version 3.0.0 which breaks the module.

This leads to error when trying on the Odoo instances using this module:

cannot import name 'HttpQueryError' from 'graphql_server' (/opt/odoo-venv/lib/python3.12/site-packages/graphql_server/init.py

To Reproduce

Affected versions: all

Steps to reproduce the behavior:

1. Try to install the module using pip

Expected behavior
Module is installed including all dependencies.

@sbidoul should we pin the package versions in the manifest or is it better to adopt the 3.0.0+?

[sbidoul]

Hm, that's strange. It's been a while since I had a look at this module.

Historically (in 12.0), this graphql_base had a dependency on graphql-server-core, not graphql_server:

rest-framework/setup/graphql_base/setup.py

Lines 6 to 11 in ce695b4

	"external_dependencies_override": {
	"python": {
	"graphql_server": "graphql-server-core",
	"graphene": "graphene<3",
	}
	}

Which Odoo version are you looking at?

[sbidoul]

Also in 13.0:

rest-framework/graphql_base/__manifest__.py

Line 14 in 1477633

"external_dependencies": {"python": ["graphene", "graphql-server-core"]},

[sbidoul]

Then it became graphql-server in 14.0, which only had 3.0.0 beta releases until a couple of days ago when it became 3.0.0.

The breaking change in graphql-server seems to have occured in 3.0.0b8.

So yeah, we can probably do graphql-server<3.0.0b8 and then work on a major upgrade of graphql_base when graphql-server stabilizes.

[ivs-cetmix]

Thank you @sbidoul ! Should I open a PR?

[sbidoul]

Yes please.

[sbidoul]

Please add a comment explaining the reason for the upper bound.