regression in 0.5.0 unknow member `nb_side_data` and `side_data` in AVStream

[marillat]

Debian unstable amd64
Apparently you were aware on this problem c608ef6

The build fail with

/build/libopenshot-dmo-0.5.0/src/FFmpegReader.cpp: In member function ‘virtual void openshot::FFmpegReader::Open()’: /build/libopenshot-dmo-0.5.0/src/FFmpegReader.cpp:569:57: error: ‘AVStream’ {aka ‘struct AVStream’} has no member named ‘nb_side_data’ 569 | for (int j = 0; j < st->nb_side_data; j++) { | ^~~~~~~~~~~~ /build/libopenshot-dmo-0.5.0/src/FFmpegReader.cpp:570:69: error: ‘AVStream’ {aka ‘struct AVStream’} has no member named ‘side_data’ 570 | AVPacketSideData *sd = &st->side_data[j]; | ^~~~~~~~~ ninja: build stopped: subcommand failed.

[rathann]

I get the above and also this on Fedora rawhide with FFmpeg 8:

/builddir/build/BUILD/libopenshot-0.5.0-build/libopenshot-0.5.0/src/FFmpegWriter.cpp: In member function ‘void openshot::FFmpegWriter::AddSphericalMetadata(const std::string&, float, float, float)’:
/builddir/build/BUILD/libopenshot-0.5.0-build/libopenshot-0.5.0/src/FFmpegWriter.cpp:2393:9: error: ‘av_stream_add_side_data’ was not declared in this scope; did you mean ‘av_packet_add_side_data’?
 2393 |         av_stream_add_side_data(video_st, AV_PKT_DATA_SPHERICAL, reinterpret_cast<uint8_t*>(map), sd_size);
      |         ^~~~~~~~~~~~~~~~~~~~~~~
      |         av_packet_add_side_data
gmake[2]: *** [src/CMakeFiles/openshot.dir/build.make:404: src/CMakeFiles/openshot.dir/FFmpegWriter.cpp.o] Error 1

[tatsuki-makino]

Hello.
It seems difficult for Qt5 WebEngine and FFmpeg 8 to coexist.

[marillat]

@tatsuki-makino ffmpeg 8 and above are completely independent of the toolkit

[tatsuki-makino]

@marillat

Building qt5-webengine on a system with ffmpeg8 installed is very difficult.
If qt5-webengine is built using the bundled ffmpeg, I'm not sure whether libopenshot will be able to work if it tries to use the ffmpeg 8 on system.

It seems that this is the reason why they are planning to remove it from Debian.

[rathann]

@marillat

Building qt5-webengine on a system with ffmpeg8 installed is very difficult.

FWIW, we managed to do it in Fedora. The patch was pretty small:
https://src.fedoraproject.org/rpms/qt5-qtwebengine/c/a6329afd8373f47f49e2541528238f1e6dfb14ae

[tatsuki-makino]

@rathann
Thank you.
My environment is FreeBSD, and it seems that the official port of it hasn't had the qt5-qtwebengine-ffmpeg"7".patch patch applied either :)
As we can see from Fedora's, the changes for 7 are huge :)

Building qt5-webengine is costly, so I plan to skip the current release version and use the development version that has started supporting qt6-.

[marillat]

@marillat

Building qt5-webengine on a system with ffmpeg8 installed is very difficult.

Here we are talking about libopensot not openshot itself.

[rathann]

@marillat
Building qt5-webengine on a system with ffmpeg8 installed is very difficult.

Here we are talking about libopenshot not openshot itself.

#1018 and #1029

[marillat]

Of course, I noticed my #1018
and have already applied #1029

The goal is to see these patches included upstream.