Skip to content

GIRClosure::find_signal_callable_info question #46

@romgrk

Description

@romgrk

node-gir/src/closure.cpp

Lines 70 to 75 in 109efbd

GIRInfoUniquePtr GIRClosure::find_signal_callable_info(guint signal_id, char *signal_name) {
// given a signal ID we want to find the GICallableInfo metadata so that
// we can know the param types & return types when marshalling data between
// the native callback and the JS callback.
// Note: this can return nullptr when the signal doesn't have a registered
// GICallableInfo. This happens notably for `notify::<property>` signals.

Here, wouldn't it be better to just use the part before :: to find the signal name?
E.g. if passed notify::label, just look for the signal called notify?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions