-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Description
Overview
Once the py-statmatch package is ready, we should replace all R/rpy2 dependencies with the pure Python implementation.
py-statmatch Repository
https://github.com/PolicyEngine/py-statmatch
Benefits
- No R installation required - Simplifies setup and CI/CD
- Better cross-platform compatibility - Works on all platforms without R
- Easier maintenance - Pure Python is easier to debug and maintain
- Faster CI builds - No need to install R and its dependencies
- Resolves documentation build issues - Fixes Fix JupyterBook 2.0 documentation build on GitHub Pages #92
Tasks
- Complete py-statmatch implementation with full test coverage
- Publish py-statmatch to PyPI
- Replace
microimpute.utils.statmatch_hotdeckwith py-statmatch - Remove
microimpute.utils.statmatch_python(temporary implementation) - Update all imports from
rpy2to py-statmatch - Remove rpy2 from optional dependencies in
pyproject.toml - Update documentation notebooks to use py-statmatch
- Update README and documentation
Code changes needed
-
In
microimpute/models/matching.py:- Replace R imports with
from statmatch import nnd_hotdeck
- Replace R imports with
-
Remove these files:
microimpute/utils/statmatch_hotdeck.pymicroimpute/utils/statmatch_python.pymicroimpute/utils/import_helpers.py
-
Update
pyproject.toml:- Remove
matchingoptional dependency group - Add
py-statmatchto main dependencies
- Remove
Metadata
Metadata
Assignees
Labels
No labels