Compile error building cross-compiler (target VAX)

[awik32]

I don't think I've encountered this particular error before:

./pftn.c: In function ‘defid2’:
./pftn.c:527:45: error: ‘GCC_ATYP_WEAKREF’ undeclared (first use in this function)
  527 |                 if ((at = attr_find(p->sap, GCC_ATYP_WEAKREF)))
      |                                             ^~~~~~~~~~~~~~~~

Configuration:

./configure --target=vax-dec-bsd --disable-gcc-compat \
  --with-incdir=/home/aw/x/vax/include --with-libdir=/home/aw/x/vax/lib \
  --with-assembler=/home/aw/x/vax/bin/as --with-linker=/home/aw/x/vax/bin/ld

Summary:

Target CPU is .................... vax
Target ABI is .................... aout
Target OS is ..................... bsd
Compiler is called ............... vax-dec-bsd-pcc
Installing compiler into ......... /usr/local/bin
Installing pre-processor into .... /usr/local/libexec
Using assembler .................. /home/aw/x/vax/bin/as
Using linker ..................... /home/aw/x/vax/bin/ld
Using Multi-Arch path ............ "x86_64-linux-gnu"
Using include path ............... /home/aw/x/vax/include
Using library path ............... /home/aw/x/vax/lib
Use libvmf ....................... no
Has TLS support .................. no
Has GCC compatibility ............ no
Has PCC debugging ................ yes
Type of wchar_t is ............... INT (4 chars)

Note that this error manifests when compiling with GCC. I'll report on the PCC compilation next.

[awik32]

See my previous post (above). The configuration is the same, but CC=pcc here.

pcc  -g -O2  -Wall -Wmissing-prototypes -Wstrict-prototypes -Wshadow -Wsign-compare -Wtruncate -D_DEFAULT_SOURCE -DPCC_DEBUG -D_ISOC99_SOURCE -Dos_bsd -Dmach_vax -I. -I. -I../.. -I../../mip -I../../arch/vax -I../../os/bsd -I../../common -c -o order.o ../../arch/vax/order.c
../../arch/vax/order.c, line 382: function doesn't match prototype
../../arch/vax/order.c, line 382: cannot recover from earlier errors: goodbye!
error: /usr/local/libexec/ccom terminated with status 1

[awik32]

I tried to figure out how to submit a pull-request, but failed.

So, I provide my changes here in the form of a "diff":

diff --git a/arch/vax/order.c b/arch/vax/order.c
index de189b8c..83ada834 100644
--- a/arch/vax/order.c
+++ b/arch/vax/order.c
@@ -379,7 +379,8 @@ offstar( p, s ) register NODE *p; {
 #endif
 
 int
-setbin( p ) register NODE *p; {
+setbin(register NODE *p) {
+/*setbin( p ) register NODE *p; {*/
 
 #if 0
        register int ro, rt;
@@ -439,7 +440,8 @@ setstr( p ) register NODE *p; { /* structure assignment */
 #endif
 
 int
-setasg( p, s ) register NODE *p; {
+setasg(register NODE *p, int s) {
+/*setasg( p, s ) register NODE *p; {*/
 
 #if 0
        /* setup for assignment operator */

[awik32]

Now, after my patch (above), pcc reports the same error as GCC (see first post in this thread):

pcc  -g -O2  -Wall -Wmissing-prototypes -Wstrict-prototypes -Wshadow -Wsign-compare -Wtruncate -D_DEFAULT_SOURCE -DPCC_DEBUG -D_ISOC99_SOURCE -Dos_bsd -Dmach_vax -I. -I. -I../.. -I../../mip -I../../arch/vax -I../../os/bsd -I../../common -c -o pftn.o ./pftn.c
./pftn.c, line 527: GCC_ATYP_WEAKREF undefined

[awik32]

I made some further changes, and now I get the build process to finish.

The changes were as follows:

diff --git a/cc/ccom/pftn.c b/cc/ccom/pftn.c
index 17a99957..06c4e60d 100644
--- a/cc/ccom/pftn.c
+++ b/cc/ccom/pftn.c
@@ -519,6 +519,7 @@ defid2(NODE *q, int class, char *astr)
 
 done:
        fixdef(p);      /* Leave last word to target */
+#ifdef GCC_COMPAT
 #ifndef HAVE_WEAKREF
        {
                struct attr *at;
@@ -528,6 +529,7 @@ done:
                        addsoname(p, at->sarg(0));
        }
 #endif
+#endif
 #ifdef PCC_DEBUG
        if (ddebug) {
                printf( "       sdf, offset: %p, %d\n\t",
diff --git a/cc/cxxcom/pftn.c b/cc/cxxcom/pftn.c
index 423f1b50..c1f18ce5 100644
--- a/cc/cxxcom/pftn.c
+++ b/cc/cxxcom/pftn.c
@@ -460,6 +460,7 @@ defid(NODE *q, int class)
 done:
        cxxsetname(p);
        fixdef(p);      /* Leave last word to target */
+#ifdef GCC_COMPAT
 #ifndef HAVE_WEAKREF
        {
                struct attr *at;
@@ -469,6 +470,7 @@ done:
                        p->soname = at->sarg(0);
        }
 #endif
+#endif
 #ifdef PCC_DEBUG
        if (ddebug) {
                printf( "       sdf, offset: %p, %d\n\t",

[awik32]

Now, I get an "install" error:

===> cc/ccom
make[2]: Entering directory '/home/aw/clone/pcc/cc/ccom'
test -z "/usr/local/libexec" || mkdir -p "/usr/local/libexec"
/usr/bin/install -c -s vax-dec-bsd-ccom /usr/local/libexec
test -f vax-dec-bsd-cc2 && /usr/bin/install -c -s vax-dec-bsd-cc2 /usr/local/libexec
make[2]: [Makefile:227: install] Error 1 (ignored)
test -z "/usr/local/share/man/man1" || mkdir -p "/usr/local/share/man/man1"
/usr/bin/install -c -m 644 ./ccom.1 /usr/local/share/man/man1/vax-dec-bsd-ccom.1
make[2]: Leaving directory '/home/aw/clone/pcc/cc/ccom'
<=== cc/ccom

But the compiler seems to do all right without this missing file.