Fix display string for function definitions

Space between name and subsequent parenthesis.

Author: andyleejordan

src/PowerShellEditorServices/Utility/VisitorUtils.cs

@@ -251,7 +251,7 @@ internal static string GetFunctionDisplayName(FunctionDefinitionAst functionDefi
             {
                 sb.Append("function");
             }
-            sb.Append(' ').Append(functionDefinitionAst.Name).Append('(');
+            sb.Append(' ').Append(functionDefinitionAst.Name).Append(" (");
             // Add parameters
             // TODO: Fix the parameters, this doesn't work for those specified in the body.
             if (functionDefinitionAst.Parameters?.Count > 0)

test/PowerShellEditorServices.Test/Language/SymbolsServiceTests.cs

@@ -165,7 +165,7 @@ public async Task FindsFunctionDefinition()
         {
             SymbolReference symbol = await GetDefinition(FindsFunctionDefinitionData.SourceDetails).ConfigureAwait(true);
             Assert.Equal("My-Function", symbol.SymbolName);
-            Assert.Equal("function My-Function($myInput)", symbol.DisplayString);
+            Assert.Equal("function My-Function ($myInput)", symbol.DisplayString);
             Assert.Equal(SymbolType.Function, symbol.SymbolType);
             AssertIsRegion(symbol.NameRegion, 1, 10, 1, 21);
             AssertIsRegion(symbol.ScriptRegion, 1, 1, 4, 2);
@@ -182,7 +182,7 @@ await psesHost.ExecutePSCommandAsync(
                 CancellationToken.None).ConfigureAwait(true);
 
             SymbolReference symbol = await GetDefinition(FindsFunctionDefinitionOfAliasData.SourceDetails).ConfigureAwait(true);
-            Assert.Equal("function My-Function($myInput)", symbol.DisplayString);
+            Assert.Equal("function My-Function ($myInput)", symbol.DisplayString);
             Assert.Equal(SymbolType.Function, symbol.SymbolType);
             AssertIsRegion(symbol.NameRegion, 1, 10, 1, 21);
             AssertIsRegion(symbol.ScriptRegion, 1, 1, 4, 2);
@@ -193,10 +193,17 @@ await psesHost.ExecutePSCommandAsync(
         public async Task FindsReferencesOnFunction()
         {
             IEnumerable<SymbolReference> symbols = await GetReferences(FindsReferencesOnFunctionData.SourceDetails).ConfigureAwait(true);
-            Assert.Collection(symbols,
-                (i) => AssertIsRegion(i.NameRegion, 1, 10, 1, 21),
-                (i) => AssertIsRegion(i.NameRegion, 3, 5, 3, 16),
-                (i) => AssertIsRegion(i.NameRegion, 10, 1, 10, 12));
+            Assert.Equal(8, symbols.Count());
+            Assert.All(symbols, (i) =>
+            {
+                Assert.Equal("My-Function", i.SymbolName);
+                Assert.Equal(SymbolType.Function, i.SymbolType);
+                if (i.IsDeclaration)
+                {
+                    Assert.Equal("function My-Function ($myInput)", i.DisplayString);
+                }
+            });
+            Assert.Distinct(symbols);
         }
 
         [Fact]