Updated approach to how we handle Ctrl+F5. We assume that we receive the launchRequest *before* any setBreakpoint requests come in. We stash the value of noDebug when we get the launchRequest and then when we get the setBreakpoint request and noDebug is true, we skip the bit that actually sets the breakpoints. However we tell VSCode that the breakpoints were set so they show up like normal in the editor.

Author: rkeithhill

src/PowerShellEditorServices.Protocol/Server/DebugAdapter.cs

@@ -73,14 +73,6 @@ protected override void Initialize()
 
         protected Task LaunchScript(RequestContext<object> requestContext)
         {
-            // If this is a run without debugging session, disable all breakpoints.
-            if (this.noDebug)
-            {
-                Task disableBreakpointsTask = 
-                    this.editorSession.DebugService.DisableAllBreakpoints();
-                Task.WhenAll(disableBreakpointsTask);
-            }
-
             return editorSession.PowerShellContext
                     .ExecuteScriptAtPath(this.scriptPathToLaunch, this.arguments)
                     .ContinueWith(
@@ -235,9 +227,11 @@ protected async Task HandleSetBreakpointsRequest(
                     LogLevel.Warning, 
                     $"Attempted to set breakpoints on a non-existing file: {setBreakpointsParams.Source.Path}");
 
+                string message = this.noDebug ? null : "Source does not exist, breakpoint not set.";
+
                 var srcBreakpoints = setBreakpointsParams.Breakpoints
                     .Select(srcBkpt => Protocol.DebugAdapter.Breakpoint.Create(
-                        srcBkpt, setBreakpointsParams.Source.Path, "Source does not exist, breakpoint not set."));
+                        srcBkpt, setBreakpointsParams.Source.Path, message, verified: this.noDebug));
 
                 // Return non-verified breakpoint message.
                 await requestContext.SendResult(
@@ -259,16 +253,20 @@ await requestContext.SendResult(
                     srcBreakpoint.Condition);
             }
 
-            BreakpointDetails[] breakpoints =
-                await editorSession.DebugService.SetLineBreakpoints(
-                    scriptFile,
-                    breakpointDetails);
+            // If this is a "run without debugging (Ctrl+F5)" session ignore requests to set breakpoints.
+            BreakpointDetails[] updatedBreakpointDetails = breakpointDetails;
+            if (!this.noDebug)
+            {
+                updatedBreakpointDetails =
+                    await editorSession.DebugService.SetLineBreakpoints(
+                        scriptFile,
+                        breakpointDetails);
+            }
 
             await requestContext.SendResult(
-                new SetBreakpointsResponseBody
-                {
+                new SetBreakpointsResponseBody {
                     Breakpoints =
-                        breakpoints
+                        updatedBreakpointDetails
                             .Select(Protocol.DebugAdapter.Breakpoint.Create)
                             .ToArray()
                 });
@@ -287,14 +285,19 @@ protected async Task HandleSetFunctionBreakpointsRequest(
                     funcBreakpoint.Condition);
             }
 
-            CommandBreakpointDetails[] breakpoints =
-                await editorSession.DebugService.SetCommandBreakpoints(
-                    breakpointDetails);
+            // If this is a "run without debugging (Ctrl+F5)" session ignore requests to set breakpoints.
+            CommandBreakpointDetails[] updatedBreakpointDetails = breakpointDetails;
+            if (!this.noDebug)
+            {
+                updatedBreakpointDetails =
+                    await editorSession.DebugService.SetCommandBreakpoints(
+                        breakpointDetails);
+            }
 
             await requestContext.SendResult(
                 new SetBreakpointsResponseBody {
                     Breakpoints =
-                        breakpoints
+                        updatedBreakpointDetails
                             .Select(Protocol.DebugAdapter.Breakpoint.Create)
                             .ToArray()
                 });

src/PowerShellEditorServices/Debugging/BreakpointDetails.cs

@@ -53,6 +53,7 @@ public static BreakpointDetails Create(
 
             return new BreakpointDetails
             {
+                Verified = true,
                 Source = source,
                 LineNumber = line,
                 ColumnNumber = column,

src/PowerShellEditorServices/Debugging/DebugService.cs

@@ -57,20 +57,6 @@ public DebugService(PowerShellContext powerShellContext)
 
         #region Public Methods
 
-        /// <summary>
-        /// Disables all breakpoints in the runspace.
-        /// </summary>
-        /// <returns></returns>
-        public async Task DisableAllBreakpoints()
-        {
-            var psCommand = new PSCommand();
-
-            psCommand.AddCommand(@"Microsoft.PowerShell.Utility\Get-PSBreakpoint");
-            psCommand.AddCommand(@"Microsoft.PowerShell.Utility\Disable-PSBreakpoint");
-
-            await this.powerShellContext.ExecuteCommand(psCommand);
-        }
-
         /// <summary>
         /// Sets the list of line breakpoints for the current debugging session.
         /// </summary>