Skip to content

ApiVersion check in Tizen.VisualStudio.ProjectSystem.VS.Debug.ProjectDebugLaunchProvider broken for some culture/locale machine setting #299

@MarP13

Description

@MarP13

I haven't found up-to-date repo for the VS extension, so I am posting the bug here.

The following check is not culture agnostic and does not work for cultures which use non-dot decimal separator. E.g. our Czech culture (cs-CZ) uses comma.
When I inject the en-US culture into VS/extension thread from debugger, I get passed the error and Tizen debugger starts correctly.

Decompiled code snippet:

if (!double.TryParse(text, out var result) || !double.TryParse(packageAPIVersion, out var result2))
{
	string message2 = $"Tizen or Package Api version or both are invalid. Please ensure all versions are correct.\nTizen Version: {text}\nPackage Api Version: {packageAPIVersion}";
	VsPackage.ShowMessage(MessageDialogType.Error, null, message2);
	return;
}

Needs to be changed to:

if (!double.TryParse(text, System.Globalization.CultureInfo.InvariantCulture , out var result) || !double.TryParse(packageAPIVersion, System.Globalization.CultureInfo.InvariantCulture, out var result2))
{
	string message2 = $"Tizen or Package Api version or both are invalid. Please ensure all versions are correct.\nTizen Version: {text}\nPackage Api Version: {packageAPIVersion}";
	VsPackage.ShowMessage(MessageDialogType.Error, null, message2);
	return;
}

Version: Visual Studio Tools for Tizen 10.0.0.0

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions