Skip to content

Commit afd637d

Browse files
authored
Fix cards not showing if journal title is empty (#136)
1 parent 68c22ba commit afd637d

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

lib/services/database_helper.dart

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -436,12 +436,12 @@ class DatabaseHelper {
436436

437437
final List<Map<String, dynamic>> maps = await db.rawQuery('''
438438
SELECT articles.*, journals.title AS journalTitle,
439-
GROUP_CONCAT(journal_issns.issn) AS issns
440-
FROM articles
441-
JOIN journals ON articles.journal_id = journals.journal_id
442-
JOIN journal_issns ON journals.journal_id = journal_issns.journal_id -- Join the journal_issns table for the correct ISSNs
443-
WHERE articles.dateLiked IS NOT NULL
444-
GROUP BY articles.article_id -- Group by article_id to ensure one entry per article
439+
GROUP_CONCAT(journal_issns.issn) AS issns
440+
FROM articles
441+
LEFT JOIN journals ON articles.journal_id = journals.journal_id
442+
LEFT JOIN journal_issns ON journals.journal_id = journal_issns.journal_id
443+
WHERE articles.dateLiked IS NOT NULL
444+
GROUP BY articles.article_id
445445
''');
446446

447447
return List.generate(maps.length, (i) {
@@ -669,12 +669,13 @@ class DatabaseHelper {
669669
final db = await database;
670670
final List<Map<String, dynamic>> maps = await db.rawQuery('''
671671
SELECT articles.*, journals.title AS journalTitle,
672-
GROUP_CONCAT(journal_issns.issn) AS issns
673-
FROM articles
674-
JOIN journals ON articles.journal_id = journals.journal_id
675-
JOIN journal_issns ON journals.journal_id = journal_issns.journal_id -- Join the journal_issns table
676-
WHERE articles.dateDownloaded IS NOT NULL
677-
GROUP BY articles.article_id -- Group by article_id to ensure one entry per article
672+
GROUP_CONCAT(journal_issns.issn) AS issns
673+
FROM articles
674+
LEFT JOIN journals ON articles.journal_id = journals.journal_id
675+
LEFT JOIN journal_issns ON journals.journal_id = journal_issns.journal_id
676+
WHERE articles.dateDownloaded IS NOT NULL
677+
GROUP BY articles.article_id
678+
678679
''');
679680

680681
return List.generate(maps.length, (i) {

0 commit comments

Comments
 (0)