From 199b050eb2928de25c65a7eeafd0e60363e3c967 Mon Sep 17 00:00:00 2001 From: Leonan Luppi Date: Thu, 26 Apr 2018 22:23:42 -0300 Subject: [PATCH 1/3] init --- routes/shopifyAuth.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/routes/shopifyAuth.js b/routes/shopifyAuth.js index 2d3ada1..e6b58a1 100644 --- a/routes/shopifyAuth.js +++ b/routes/shopifyAuth.js @@ -16,6 +16,9 @@ module.exports = function createShopifyAuthRoutes({ auth(request, response) { const { query, baseUrl } = request; const { shop } = query; + + //Remove unnecessary / + baseUrl = baseUrl.replace(/^\//, ''); if (shop == null) { return response.status(400).send('Expected a shop query parameter'); From 1f15616babcb844211edc22bd9105441cf657549 Mon Sep 17 00:00:00 2001 From: Leonan Luppi Date: Thu, 26 Apr 2018 22:24:25 -0300 Subject: [PATCH 2/3] Remove first / at baseURL --- routes/shopifyAuth.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/routes/shopifyAuth.js b/routes/shopifyAuth.js index e6b58a1..f32b44e 100644 --- a/routes/shopifyAuth.js +++ b/routes/shopifyAuth.js @@ -17,7 +17,7 @@ module.exports = function createShopifyAuthRoutes({ const { query, baseUrl } = request; const { shop } = query; - //Remove unnecessary / + //Remove first / at baseURL baseUrl = baseUrl.replace(/^\//, ''); if (shop == null) { From c8d664652ed82bd5bb67ce4a652d4ac6f2df8018 Mon Sep 17 00:00:00 2001 From: Leonan Luppi Date: Thu, 26 Apr 2018 23:36:25 -0300 Subject: [PATCH 3/3] change const to let --- routes/shopifyAuth.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/routes/shopifyAuth.js b/routes/shopifyAuth.js index f32b44e..2ff843e 100644 --- a/routes/shopifyAuth.js +++ b/routes/shopifyAuth.js @@ -14,7 +14,7 @@ module.exports = function createShopifyAuthRoutes({ return { // This function initializes the Shopify OAuth Process auth(request, response) { - const { query, baseUrl } = request; + let { query, baseUrl } = request; const { shop } = query; //Remove first / at baseURL