Skip to content

Tidy std::unique_ptr<>&& usage as an argument and just use std::unique_ptr<> #3

@SingingTree

Description

@SingingTree

Code such as

void SetAtoms(std::unique_ptr<AtomHolder>&& atom_holder);

could be

void SetAtoms(std::unique_ptr<AtomHolder> atom_holder);

without changing much code wise or functionality wise. This complies better with Google style (though I kinda prefer the former).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions