Skip to content

spring-launcher lib leaking sockets when run without launcher #548

@p2004a

Description

@p2004a

When running Chobby with libs/spring-launcher/api_spring_launcher_loader.lua loaded (like BYAR-Chobby), but without the spring-lobby actually running e.g manual run:

./spring -isolation -write-dir ~/Documents/Beyond\ All\ Reason -menu rapid://byar-chobby:test

The library is not cleaning up sockets after connection fails, this causes reaching high number of open descriptors, and game can crash with:

[t=00:00:15.766676][f=-000001] [LuaMenu] Error: In Update(): [string "libs/spring-launcher/luaui/widgets/api_spri..."]:93: attempt to index upvalue 'client' (a nil value)
[t=00:00:15.766724][f=-000001] [LuaMenu] Error: Removed widget: <spring-launcher>
[t=00:00:15.807952][f=-000001] [CrashHandler] Error: Segmentation fault in Spring 105.1.1-1214-gcf8d087 BAR105
[t=00:00:15.807995][f=-000001] [CrashHandler] Error: Halted Stacktrace for Spring 105.1.1-1214-gcf8d087 BAR105 (SIGSEGV) using libunwind:
[t=00:00:15.857624][f=-000001] [CrashHandler] Warning: [TranslateStackTrace] addr2line not found!

Workaround is to increase the limit on file descriptors with ulimit -Sn 50000 but it's still annoying.

@Beherith not sure if belongs here or in BYAR-Chobby repo.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions