Refactored powershell causes Containerfile to fail loading

[deathaxe]

[michaelblyons]

Can you change the include to scope:source.powershell#statements?

I think this is the same problem as I had when C# added a shebang and HTML (C#) couldn't pop: 1 out of it. I had to change that match to pop: 3, but I have a "someday" task to try including the after-shebang context instead of main.

If this works, I can put a statements context into PowerShell for 4.2.0, like

  main:
    - include: statements
  statements:
    - include: everything currently in main

so that ContainerFile can release a working version before PowerShell 5.0

[deathaxe]

Doesn't seem to make a difference.

[michaelblyons]

Yeah, I'm trying things now against Keith's test file. Best so far is

contexts:
  embedded_shell:
    - meta_scope: source.powershell.embedded.containerfile
    - match: (?=\S)
      embed: scope:source.powershell
      escape: (?<!`)$\n
    - match: ^(?!.*`$)
      pop: 1

[deathaxe]

Same, here. As soon as I attempt to add highlighting for line continuation via extended PowerShell syntax, it starts all over again however.

%YAML 1.2
---
# See http://www.sublimetext.com/docs/3/syntax.html
scope: source.powershell.embedded.containerfile
version: 2
hidden: true

extends: Packages/PowerShell/PowerShell.sublime-syntax

contexts:
  prototype:
    - meta_prepend: true
    - include: scope:source.containerfile#eat-bare-comments
    - include: scope:source.containerfile#line-continuation

Commenting out the C# embedding patterns in Powershell seems to fix the issue.

[michaelblyons]

Is it possible that C# itself is the problem? I expect that eventually someone will want to write two extended C# syntaxes in PowerShell to handle string escapes, but I hoped to wait on that.

[deathaxe]

Any complex enough syntax is likely to cause trouble when pushed on stack using with_prototype.

It may be related with C# pushing SQL using with_prototype, which at least may cause dynamically created contexts to exponentially increase beyond sanity limit. Maybe multiple levels of pusing different syntaxes may even cause real infinite loops.

TBH, I am already surprised pushing SQL using with_prototype in Python and C# working rather well. RegExp is simple and straight forwared enough to be safe, but SQL is already rather complex.

[michaelblyons]

Ripping SQL out of C# stops the sanity limit from being reached. The Containerfile tests fail, but my embed sample above can fix it.