We don't have an established house style for shell scripts, nor any upstream shell-oriented project(s) to follow.
Absent any more compelling alternatives, let's adopt YSAP Bash Style.
Update: are shellcheck+shfmt a "more compelling alternative"? (See https://github.com/ublue-os/image-template#lint-and-format)