ROCm distrobox executes init_hooks on every startup #1
Description
About
As the title sais. If AMD updates ROCm on their end the older ROCm package will eventually vanish a short time after.
The issue with this is, that distrobox always runs the init_hooks on every launch. This means it will always setup ROCm. While installing the ROCm package this is not an issue as apt will validate if the package already has been installed and just continue. That's why only the first init of the container takes so long and becomes significantly shorter later on.
This lead to me thinking all is good. But as I found out today upon launching the rocm container on my local machine the startup failed. Because of the missing rocm package. Hence I had to re-create the rocm container with the already updated assemble file. Now it works again. However this issue will re-appear the next time rocm will be updated by AMD.
Therefore I need a fix for this.
Ideas
- Find a way to use "one-shot" init_hooks in distrobox. Which only get execute once and the very first time the box is created / opened for the first time
- Replace the init_hook with one which will download a shell script instead which will do the ROCm setup. Therefore I can manage the shell script here and make sure future containers will use the script to install ROCm. While the script will be aware of a possibly changing ROCm version on AMDs repos. Also this script could serve as a sort of automated updater for ROCm.
I need to wrap my head around this. Just opening the issue here so I will not forget about it.