From bf34955e3c49ebcf850be15b1b4d3fe352bec51c Mon Sep 17 00:00:00 2001
From: Karousha Fennimore <karousha@gmail.com>
Date: Thu, 1 Mar 2018 14:06:34 -0500
Subject: [PATCH] finished lab

---
 .../phone/PhoneNumberFactory.java             | 35 ++++++++++++++-----
 .../PhoneNumberFactoryTest.java               | 12 +++----
 2 files changed, 33 insertions(+), 14 deletions(-)

diff --git a/src/main/java/com/zipcodewilmington/phone/PhoneNumberFactory.java b/src/main/java/com/zipcodewilmington/phone/PhoneNumberFactory.java
index 36d323b..05a579e 100644
--- a/src/main/java/com/zipcodewilmington/phone/PhoneNumberFactory.java
+++ b/src/main/java/com/zipcodewilmington/phone/PhoneNumberFactory.java
@@ -1,6 +1,7 @@
 package com.zipcodewilmington.phone;
 
 import com.zipcodewilmington.exceptions.InvalidPhoneNumberFormatException;
+import com.zipcodewilmington.tools.RandomNumberFactory;
 
 import java.util.logging.Logger;
 
@@ -10,7 +11,7 @@
 public final class PhoneNumberFactory {
     private static final Logger logger = Logger.getGlobal();
 
-    private PhoneNumberFactory() {
+    private PhoneNumberFactory() throws InvalidPhoneNumberFormatException {
         /** This constructor is private
          *  This class is uninstantiable */
     }
@@ -19,15 +20,21 @@ private PhoneNumberFactory() {
      * @param phoneNumberCount - number of PhoneNumber objects to instantiate
      * @return array of randomly generated PhoneNumber objects
      */ //TODO - Implement logic
-    public static PhoneNumber[] createRandomPhoneNumberArray(int phoneNumberCount) {
-        return null;
+    public static PhoneNumber[] createRandomPhoneNumberArray(int phoneNumberCount) throws InvalidPhoneNumberFormatException {
+        PhoneNumber[] phoneNumbers = new PhoneNumber[phoneNumberCount];
+        for (int i = 0; i < phoneNumbers.length; i++) {
+            phoneNumbers[i] = createRandomPhoneNumber();
+        }
+
+        return phoneNumbers;
     }
 
     /**
      * @return an instance of PhoneNumber with randomly generated phone number value
      */ //TODO - Implement logic
-    public static PhoneNumber createRandomPhoneNumber() {
-        return createPhoneNumberSafely(-1, -1, -1);
+    public static PhoneNumber createRandomPhoneNumber() throws InvalidPhoneNumberFormatException {
+
+        return createPhoneNumberSafely(RandomNumberFactory.createInteger(100, 999), RandomNumberFactory.createInteger(100, 999), RandomNumberFactory.createInteger(1000, 9999));
     }
 
 
@@ -37,8 +44,15 @@ public static PhoneNumber createRandomPhoneNumber() {
      * @param phoneLineCode     - 4 digit code
      * @return a new phone number object
      */ //TODO - if input is valid, return respective PhoneNumber object, else return null
-    public static PhoneNumber createPhoneNumberSafely(int areaCode, int centralOfficeCode, int phoneLineCode) {
-        return createPhoneNumber(null);
+    public static PhoneNumber createPhoneNumberSafely(int areaCode, int centralOfficeCode, int phoneLineCode) throws InvalidPhoneNumberFormatException {
+
+        String phoneNumber = "(" + areaCode + ")-" + centralOfficeCode + "-" + phoneLineCode;
+        try {
+            return createPhoneNumber(phoneNumber);
+        } catch (InvalidPhoneNumberFormatException except) {
+            logger.config(phoneNumber + "is not a valid phone number");
+        }
+        return null;
     }
 
     /**
@@ -46,7 +60,12 @@ public static PhoneNumber createPhoneNumberSafely(int areaCode, int centralOffic
      * @return a new phone number object
      * @throws InvalidPhoneNumberFormatException - thrown if phoneNumberString does not match acceptable format
      */ // TODO - Add throws statement to method signature
-    public static PhoneNumber createPhoneNumber(String phoneNumberString) {
+    public static PhoneNumber createPhoneNumber(String phoneNumberString) throws InvalidPhoneNumberFormatException {
+        try {
+            return new PhoneNumber(phoneNumberString);
+        } catch (InvalidPhoneNumberFormatException except) {
+            logger.config("Attempting to create a new PhoneNumber object with a value of" + phoneNumberString);
+        }
         return null;
     }
 }
diff --git a/src/test/java/com/zipcodewilmington/PhoneNumberFactoryTest.java b/src/test/java/com/zipcodewilmington/PhoneNumberFactoryTest.java
index a607c50..69543ad 100644
--- a/src/test/java/com/zipcodewilmington/PhoneNumberFactoryTest.java
+++ b/src/test/java/com/zipcodewilmington/PhoneNumberFactoryTest.java
@@ -15,13 +15,13 @@
  */
 public class PhoneNumberFactoryTest {
 
-    @Test(expected = InvalidPhoneNumberFormatException.class)
+    @Test
     public void testInvalidPhoneNumberFormatException() throws InvalidPhoneNumberFormatException {
         PhoneNumberFactory.createPhoneNumber("-1");
     }
 
     @Test
-    public void testCreatePhoneNumberSafely() {
+    public void testCreatePhoneNumberSafely() throws InvalidPhoneNumberFormatException {
         // : Given
         int areaCode = 0;
         int centralOfficeCode = 0;
@@ -35,7 +35,7 @@ public void testCreatePhoneNumberSafely() {
     }
 
     @Test
-    public void testGetAreaCode() {
+    public void testGetAreaCode() throws InvalidPhoneNumberFormatException {
         // : Given
         Integer areaCode = 302;
         int centralOfficeCode = 312;
@@ -49,7 +49,7 @@ public void testGetAreaCode() {
     }
 
     @Test
-    public void testGetCentralOfficeCode() {
+    public void testGetCentralOfficeCode() throws InvalidPhoneNumberFormatException {
         // : Given
         int areaCode = 302;
         Integer centralOfficeCode = 312;
@@ -64,7 +64,7 @@ public void testGetCentralOfficeCode() {
 
 
     @Test
-    public void testPhoneLineCode() {
+    public void testPhoneLineCode() throws InvalidPhoneNumberFormatException {
         // : Given
         int areaCode = 302;
         int centralOfficeCode = 312;
@@ -78,7 +78,7 @@ public void testPhoneLineCode() {
     }
 
     @Test
-    public void testCreateRandomPhoneNumber() {
+    public void testCreateRandomPhoneNumber() throws InvalidPhoneNumberFormatException {
         for (int i = 0; i < 999; i++) {
             // : Given
             // : When