From 290e5cbcf7b5e3fd155c8938b08ea580f4a293a7 Mon Sep 17 00:00:00 2001 From: foamyguy Date: Fri, 12 Dec 2025 16:23:34 -0600 Subject: [PATCH 1/3] fix for TextBox when initialized with an empty text --- adafruit_display_text/text_box.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/adafruit_display_text/text_box.py b/adafruit_display_text/text_box.py index 172a3c7..ba7de91 100644 --- a/adafruit_display_text/text_box.py +++ b/adafruit_display_text/text_box.py @@ -94,6 +94,9 @@ def __init__( font, ) + if not kwargs.get("text", ""): + kwargs["text"] = " " + super().__init__(font, **kwargs) self._text = "\n".join(self.lines) From a9131379ccf9b3c570181ca9360aece72d7ef6be Mon Sep 17 00:00:00 2001 From: foamyguy Date: Fri, 12 Dec 2025 17:06:39 -0600 Subject: [PATCH 2/3] use _full_text in TextBox & put back to empty string after super init. --- adafruit_display_text/text_box.py | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/adafruit_display_text/text_box.py b/adafruit_display_text/text_box.py index ba7de91..e6b28d2 100644 --- a/adafruit_display_text/text_box.py +++ b/adafruit_display_text/text_box.py @@ -94,19 +94,24 @@ def __init__( font, ) - if not kwargs.get("text", ""): + text_empty = False + if kwargs.get("text", "") == "": + text_empty = True kwargs["text"] = " " super().__init__(font, **kwargs) - self._text = "\n".join(self.lines) - self._text = self._replace_tabs(self._text) - self._original_text = self._text + if text_empty: + self._full_text = "" + + self._full_text = "\n".join(self.lines) + self._full_text = self._replace_tabs(self._full_text) + self._original_text = self._full_text # call the text updater with all the arguments. self._reset_text( font=font, - text=self._text, + text=self._full_text, line_spacing=self._line_spacing, scale=self.scale, ) From 437f6a29c5c9c58f929afc15c464a9a492599f65 Mon Sep 17 00:00:00 2001 From: foamyguy Date: Fri, 12 Dec 2025 17:08:46 -0600 Subject: [PATCH 3/3] simplify expression for lint --- adafruit_display_text/text_box.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_display_text/text_box.py b/adafruit_display_text/text_box.py index e6b28d2..92eec7f 100644 --- a/adafruit_display_text/text_box.py +++ b/adafruit_display_text/text_box.py @@ -95,7 +95,7 @@ def __init__( ) text_empty = False - if kwargs.get("text", "") == "": + if not kwargs.get("text", ""): text_empty = True kwargs["text"] = " "