From 4693f99ce77eb667eb03a59006bd12e266e8103b Mon Sep 17 00:00:00 2001 From: rayworks Date: Wed, 17 Dec 2025 09:46:53 +0800 Subject: [PATCH 1/2] fix: center the video player in the landscape mode --- .../android/samples/socialite/ui/player/VideoPlayerScreen.kt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/com/google/android/samples/socialite/ui/player/VideoPlayerScreen.kt b/app/src/main/java/com/google/android/samples/socialite/ui/player/VideoPlayerScreen.kt index 6024df60..52f908dc 100644 --- a/app/src/main/java/com/google/android/samples/socialite/ui/player/VideoPlayerScreen.kt +++ b/app/src/main/java/com/google/android/samples/socialite/ui/player/VideoPlayerScreen.kt @@ -26,9 +26,7 @@ import android.os.Build import android.util.Rational import androidx.activity.ComponentActivity import androidx.compose.foundation.focusable -import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Box -import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.fillMaxSize import androidx.compose.foundation.layout.padding import androidx.compose.material.icons.Icons @@ -46,6 +44,7 @@ import androidx.compose.runtime.mutableStateOf import androidx.compose.runtime.remember import androidx.compose.runtime.rememberUpdatedState import androidx.compose.runtime.setValue +import androidx.compose.ui.Alignment import androidx.compose.ui.Modifier import androidx.compose.ui.graphics.Color import androidx.compose.ui.graphics.toAndroidRectF @@ -127,7 +126,7 @@ private fun VideoPlayerScreen( Scaffold( topBar = { VideoPlayerTopAppBar(onCloseButtonClicked) }, ) { innerPadding -> - Column(modifier = modifier.fillMaxSize(), verticalArrangement = Arrangement.Center) { + Box(modifier = modifier.fillMaxSize(), contentAlignment = Alignment.Center) { VideoPlayer(player, shouldEnterPipMode, Modifier.padding(innerPadding)) } } From 918431424139ac3b072a9d832c3a609106bbd44e Mon Sep 17 00:00:00 2001 From: rayworks Date: Wed, 17 Dec 2025 10:27:15 +0800 Subject: [PATCH 2/2] Apply padding to the container according to the review feedback --- .../samples/socialite/ui/player/VideoPlayerScreen.kt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/google/android/samples/socialite/ui/player/VideoPlayerScreen.kt b/app/src/main/java/com/google/android/samples/socialite/ui/player/VideoPlayerScreen.kt index 52f908dc..504f4570 100644 --- a/app/src/main/java/com/google/android/samples/socialite/ui/player/VideoPlayerScreen.kt +++ b/app/src/main/java/com/google/android/samples/socialite/ui/player/VideoPlayerScreen.kt @@ -126,8 +126,13 @@ private fun VideoPlayerScreen( Scaffold( topBar = { VideoPlayerTopAppBar(onCloseButtonClicked) }, ) { innerPadding -> - Box(modifier = modifier.fillMaxSize(), contentAlignment = Alignment.Center) { - VideoPlayer(player, shouldEnterPipMode, Modifier.padding(innerPadding)) + Box( + modifier = modifier + .fillMaxSize() + .padding(innerPadding), + contentAlignment = Alignment.Center, + ) { + VideoPlayer(player, shouldEnterPipMode) } } }