Revert snapshot only if volume is not attached to a running VM

[GabrielBrascher]

ISSUE TYPE

• Bug Report
• Improvement Request

COMPONENT NAME

Ceph/KVM

CLOUDSTACK VERSION

4.13
4.14
master

SUMMARY

Snapshotting and reverting snapshots on KVM + Ceph work fine; however, it is allowed to revert to the snapshot while the VM is running. To avoid issues during the revert of a snapshot we need to make sure the VM is stopped.

If the Volume is attached to a VM and that VM is running, snapshot revert should not be allowed.

[wido]

I tested and verified this with:

• CloudStack 4.13.1
• Ceph Octopus (15)

The revert worked, but as the VM was running it didn't have any effect.

After stopping and reverting again it worked as expected.

[DaanHoogland]

Atre you saying "not a bug", @wido ?

[wido]

Well, technically you can do this revert, but it won't have any effect. In order to guarantee data consistency you would need to Stop the VM before doing so.

[DaanHoogland]

so still the question remains, do we silently failing consider a bug or well behaved handling of an exception? i.e. how should this be handled?

1. including the stop when a revert is requested
2. throw an error when the vm is running
3. silently ignore the request

[DaanHoogland]

3. meaning this issue being closed as "not a bug"

[wido]

I would say Option 2: Throw an error when the VM is running

[DaanHoogland]

as you guys can test this will you implement a PR @GabrielBrascher @wido ?

[wido]

Yes. @GabrielBrascher is working on a PR. This issue is here to track it and close once the PR is merged.