From 62993fb21057e534c7d004196f3a0bfce8b27cc6 Mon Sep 17 00:00:00 2001 From: Neil C Smith Date: Mon, 19 Jan 2026 17:18:04 +0000 Subject: [PATCH 1/4] Update GitHub workflow test matrix, OS and actions. --- .github/workflows/test.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 3af5fb7..ef70827 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -28,8 +28,8 @@ jobs: name: Build and test on ${{ matrix.os }}, JDK ${{ matrix.java }} strategy: matrix: - java: [ '17', '24' ] - os: [ 'ubuntu-24.04', 'windows-2022', 'macos-14' ] + java: [ '21', '25' ] + os: [ 'ubuntu-24.04', 'windows-2022', 'macos-15' ] runs-on: ${{ matrix.os }} steps: @@ -49,20 +49,20 @@ jobs: run: ./mvnw --batch-mode --no-transfer-progress clean verify - name: Install Linux dependencies - if: matrix.os == 'ubuntu-24.04' && matrix.java == '24' + if: matrix.os == 'ubuntu-24.04' && matrix.java == '25' run : | sudo apt update sudo apt install rpm - name: Test packaging - if: matrix.java == '24' + if: matrix.java == '25' env: INNOSETUP_PATH: 'C:\\Program Files (x86)\\Inno Setup 6\\iscc.exe' run : java .github/scripts/PackageTest.java - name: Upload test package artefacts - uses: actions/upload-artifact@v5 - if: matrix.java == '24' + uses: actions/upload-artifact@v6 + if: matrix.java == '25' with: name: ${{ matrix.os }}-test path: "target/package-test/output/" From eeb99a80a0dcbee297685f5903f6c2d82af82025 Mon Sep 17 00:00:00 2001 From: Neil C Smith Date: Mon, 19 Jan 2026 17:40:36 +0000 Subject: [PATCH 2/4] Remove deprecated arch options from AppImage and macOS packagers. --- .../nbpackage/appimage/AppImagePackager.java | 16 +++------------- .../nbpackage/appimage/AppImageTask.java | 5 ++--- .../netbeans/nbpackage/macos/AppBundleTask.java | 1 - .../apache/netbeans/nbpackage/macos/MacOS.java | 10 ---------- .../netbeans/nbpackage/macos/PkgPackager.java | 3 +-- 5 files changed, 6 insertions(+), 29 deletions(-) diff --git a/src/main/java/org/apache/netbeans/nbpackage/appimage/AppImagePackager.java b/src/main/java/org/apache/netbeans/nbpackage/appimage/AppImagePackager.java index 526be24..1a29278 100644 --- a/src/main/java/org/apache/netbeans/nbpackage/appimage/AppImagePackager.java +++ b/src/main/java/org/apache/netbeans/nbpackage/appimage/AppImagePackager.java @@ -57,16 +57,6 @@ public class AppImagePackager implements Packager { MESSAGES.getString("option.category.default"), MESSAGES.getString("option.category.help")); - /** - * Architecture of AppImage to create. Defaults to parsing from appimagetool - * file name. - */ - @Deprecated(forRemoval = true) - static final Option APPIMAGE_ARCH - = Option.ofString("package.appimage.arch", - MESSAGES.getString("option.arch.help")) - .withStatus(Option.Status.DEPRECATED); - /** * Optional path to custom .desktop template. */ @@ -80,7 +70,7 @@ public class AppImagePackager implements Packager { static final Template DESKTOP_TEMPLATE = Template.of(DESKTOP_TEMPLATE_PATH, "AppImage.desktop.template", () -> AppImagePackager.class.getResourceAsStream("AppImage.desktop.template")); - + /** * Optional path to custom AppRun launcher template. */ @@ -97,8 +87,8 @@ public class AppImagePackager implements Packager { private static final List> APPIMAGE_OPTIONS = List.of(APPIMAGE_TOOL, APPIMAGE_ICON, APPIMAGE_CATEGORY, - APPIMAGE_ARCH, DESKTOP_TEMPLATE_PATH, LAUNCHER_TEMPLATE_PATH); - + DESKTOP_TEMPLATE_PATH, LAUNCHER_TEMPLATE_PATH); + private static final List