From 64e47fe9628dbbef49c9b69784d715705174d755 Mon Sep 17 00:00:00 2001
From: cgaetan <gaetan.chaboussie@nereide.fr>
Date: Wed, 5 Nov 2025 11:03:00 +0100
Subject: [PATCH 1/2] Changed: Migration to Java 21 (OFBIZ-13306)

Migration to Java 21

Thanks: Jacques for the warnings work and Nicolas.
---
 .../main/java/org/apache/ofbiz/scrum/ScrumServices.java    | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/scrum/src/main/java/org/apache/ofbiz/scrum/ScrumServices.java b/scrum/src/main/java/org/apache/ofbiz/scrum/ScrumServices.java
index 098cba7d2..6b6156620 100644
--- a/scrum/src/main/java/org/apache/ofbiz/scrum/ScrumServices.java
+++ b/scrum/src/main/java/org/apache/ofbiz/scrum/ScrumServices.java
@@ -28,6 +28,7 @@
 import java.util.Locale;
 import java.util.Map;
 import java.util.Set;
+
 import org.apache.ofbiz.base.util.Debug;
 import org.apache.ofbiz.base.util.StringUtil;
 import org.apache.ofbiz.base.util.UtilMisc;
@@ -141,14 +142,14 @@ public static Map<String, Object> viewScrumRevision(DispatchContext ctx, Map<Str
             if (UtilValidate.isNotEmpty(repository) && UtilValidate.isNotEmpty(revision)
                     && UtilValidate.isValidUrl(repository) && UtilValidate.isInteger(revision)) {
                 String logline = null;
-                Process logProcess = Runtime.getRuntime().exec("svn",
+                Process logProcess = Runtime.getRuntime().exec(new String[]{"svn",},
                         new String[]{"log", "-r", revision, repository});
                 BufferedReader logIn = new BufferedReader(new InputStreamReader(logProcess.getInputStream()));
                 while ((logline = logIn.readLine()) != null) {
                     logMessage.append(logline).append("\n");
                 }
                 String diffline = null;
-                Process diffProcess = Runtime.getRuntime().exec("svn",
+                Process diffProcess = Runtime.getRuntime().exec(new String[]{"svn",},
                         new String[]{"diff", "-r", StringUtil.addToNumberString(revision.trim(), -1) + ":" + revision, repository});
                 BufferedReader diffIn = new BufferedReader(new InputStreamReader(diffProcess.getInputStream()));
                 while ((diffline = diffIn.readLine()) != null) {
@@ -188,7 +189,7 @@ public static Map<String, Object> retrieveMissingScrumRevision(DispatchContext c
                 for (int i = 1; i <= revision; i++) {
                     String logline = null;
                     List<String> logMessageList = new LinkedList<>();
-                    Process logProcess = Runtime.getRuntime().exec("svn",
+                    Process logProcess = Runtime.getRuntime().exec(new String[]{"svn",},
                             new String[]{"log", "-r", String.valueOf(i), repositoryRoot});
                     BufferedReader logIn = new BufferedReader(new InputStreamReader(logProcess.getInputStream()));
                     while ((logline = logIn.readLine()) != null) {

From 1280f4e4f2624915dfa71beae0fa6b9b80bbbfc4 Mon Sep 17 00:00:00 2001
From: cgaetan <gaetan.chaboussie@nereide.fr>
Date: Wed, 5 Nov 2025 11:06:08 +0100
Subject: [PATCH 2/2] Changed: Migration to Java 21 (OFBIZ-13306)

Migration to Java 21
Fix CheckStyle

Thanks: Jacques for the warnings work and Nicolas.
---
 .../src/main/java/org/apache/ofbiz/scrum/ScrumServices.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scrum/src/main/java/org/apache/ofbiz/scrum/ScrumServices.java b/scrum/src/main/java/org/apache/ofbiz/scrum/ScrumServices.java
index 6b6156620..52891a271 100644
--- a/scrum/src/main/java/org/apache/ofbiz/scrum/ScrumServices.java
+++ b/scrum/src/main/java/org/apache/ofbiz/scrum/ScrumServices.java
@@ -142,14 +142,14 @@ public static Map<String, Object> viewScrumRevision(DispatchContext ctx, Map<Str
             if (UtilValidate.isNotEmpty(repository) && UtilValidate.isNotEmpty(revision)
                     && UtilValidate.isValidUrl(repository) && UtilValidate.isInteger(revision)) {
                 String logline = null;
-                Process logProcess = Runtime.getRuntime().exec(new String[]{"svn",},
+                Process logProcess = Runtime.getRuntime().exec(new String[]{"svn"},
                         new String[]{"log", "-r", revision, repository});
                 BufferedReader logIn = new BufferedReader(new InputStreamReader(logProcess.getInputStream()));
                 while ((logline = logIn.readLine()) != null) {
                     logMessage.append(logline).append("\n");
                 }
                 String diffline = null;
-                Process diffProcess = Runtime.getRuntime().exec(new String[]{"svn",},
+                Process diffProcess = Runtime.getRuntime().exec(new String[]{"svn"},
                         new String[]{"diff", "-r", StringUtil.addToNumberString(revision.trim(), -1) + ":" + revision, repository});
                 BufferedReader diffIn = new BufferedReader(new InputStreamReader(diffProcess.getInputStream()));
                 while ((diffline = diffIn.readLine()) != null) {
@@ -189,7 +189,7 @@ public static Map<String, Object> retrieveMissingScrumRevision(DispatchContext c
                 for (int i = 1; i <= revision; i++) {
                     String logline = null;
                     List<String> logMessageList = new LinkedList<>();
-                    Process logProcess = Runtime.getRuntime().exec(new String[]{"svn",},
+                    Process logProcess = Runtime.getRuntime().exec(new String[]{"svn"},
                             new String[]{"log", "-r", String.valueOf(i), repositoryRoot});
                     BufferedReader logIn = new BufferedReader(new InputStreamReader(logProcess.getInputStream()));
                     while ((logline = logIn.readLine()) != null) {