From 7bacf56d62db9f45d6210a6d339f399250d3be12 Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Sat, 19 Nov 2022 03:00:57 +0000 Subject: [PATCH] vuln-fix: Temporary File Information Disclosure This fixes temporary file information disclosure vulnerability due to the use of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by using the `Files.createTempFile()` method which sets the correct posix permissions. Weakness: CWE-377: Insecure Temporary File Severity: Medium CVSSS: 5.5 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/18 Co-authored-by: Moderne --- src/main/java/org/apache/servicemix/util/FileUtil.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/apache/servicemix/util/FileUtil.java b/src/main/java/org/apache/servicemix/util/FileUtil.java index 7b4e550..43212f6 100644 --- a/src/main/java/org/apache/servicemix/util/FileUtil.java +++ b/src/main/java/org/apache/servicemix/util/FileUtil.java @@ -29,6 +29,7 @@ import java.nio.channels.Channels; import java.nio.channels.ReadableByteChannel; import java.nio.channels.WritableByteChannel; +import java.nio.file.Files; import java.util.Enumeration; import java.util.zip.ZipEntry; import java.util.zip.ZipFile; @@ -174,7 +175,7 @@ public static File unpackArchive(URL url, File targetDir) } InputStream in = new BufferedInputStream(url.openStream()); // make sure we get the actual file - File zip = File.createTempFile("arc", ".zip", targetDir); + File zip = Files.createTempFile(targetDir.toPath(), "arc", ".zip").toFile(); OutputStream out = new BufferedOutputStream(new FileOutputStream(zip)); copyInputStream(in, out); out.close();