Kz conversion with inner potential V0 incorrect

[joshpw]

Hello,

I wanted to report a potential bug that I found (or please let me know if you disagree).

In kz_conversion.py the function "_kp_to_polar" explicitly depends on the inner_potential, summing it into the formula for phi[i]. However, I am not sure this is correct and think that here the inner_potential should just be removed from the code. The specific line is:

phi[i] = (
np.arcsin(
kp[i]
/ (arpes.constants.K_INV_ANGSTROM * np.sqrt(kinetic_energy[i] + inner_potential))
)
+ angle_offset
)

Thank you for maintaining this code base.

[arafune]

Could you throw PR?

[joshpw]

Honestly not too familiar using github generally and I changed a bunch of additional (not bugged) things in my version.

As far as I can tell the only change needed is to remove "+ inner_potential" from that one line of code in the function "_kp_to_polar" in file "kz_conversion.py" to fix this issue.

[arafune]

remove "+ inner_potential" from that one line of code in the function "_kp_to_polar" in file "kz_conversion.py" to fix this issue.

I don't know if that's enough, so please throw us a PR, and then the code automatically will be tested automatically, and then I merge it if there are no errors. I don't use this part of the cod at the moment and don't plan to, so I can't take the time to look into it myself.

Creating a PR isn’t that difficult. If you want to essentially fix it, please cooperate with me.