Skip to content

"Drawing out of range" - floating-point issues #18

@nylen

Description

@nylen
$ python gcodeplot/gcodeplot.py --work-z=0.9 --lift-delta=0.6 --safe-delta-z=3 --z-speed=45 --pens=pens.txt mandala.svg
Optimizing...[0%][5%][10%][15%][20%][25%][30%][35%][40%][45%][50%][55%][60%][65%][70%][75%][80%][85%][90%][95%]
Transport time improvement: 89.1% (took 1.64 seconds).
Drawing out of range: [0.0, 5.291666695939057e-06] [176.38888447916665, 176.38888977083334]
No points.

Files needed to reproduce the issue: gcodeplot-fpbug.zip

I commented out the "Drawing out of range" section to make the print work, and it turned out awesome. I think it would be better to add a tolerance here though (or just allow negative values, since they're not necessarily invalid).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions