From adaa0b3c1baa5df70a8ffcf4d77897b8a323dc77 Mon Sep 17 00:00:00 2001 From: Tilde Ann Thurium Date: Tue, 17 Jul 2018 13:50:46 -0700 Subject: [PATCH 1/5] expose method for setting gitHubUser --- lib/metrics.js | 3 ++- lib/reporter.js | 4 ++++ package.json | 2 +- spec/metrics-spec.js | 9 +++++++++ 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/lib/metrics.js b/lib/metrics.js index 7cfcc2e..b5405ab 100644 --- a/lib/metrics.js +++ b/lib/metrics.js @@ -36,7 +36,8 @@ module.exports = { sendEvent: Reporter.sendEvent.bind(Reporter), sendTiming: Reporter.sendTiming.bind(Reporter), addTiming: Reporter.addTiming.bind(Reporter), - sendException: Reporter.sendException.bind(Reporter) + sendException: Reporter.sendException.bind(Reporter), + setGitHubUser: Reporter.setGitHubUser.bind(Reporter) } }, diff --git a/lib/reporter.js b/lib/reporter.js index 9807ac5..eff5f7e 100644 --- a/lib/reporter.js +++ b/lib/reporter.js @@ -126,6 +126,10 @@ class Reporter { this.send(params) } + static setGitHubUser(gitHubUser) { + this.getStore().setGitHubUser(gitHubUser); + } + // Private static getStore () { if (!store) { diff --git a/package.json b/package.json index d3fa30c..2a48894 100644 --- a/package.json +++ b/package.json @@ -19,7 +19,7 @@ "fs-plus": "^3.0.0", "grim": "^2.0.1", "node-uuid": "~1.4.7", - "telemetry-github": "0.0.11" + "telemetry-github": "0.0.12" }, "devDependencies": { "standard": "*", diff --git a/spec/metrics-spec.js b/spec/metrics-spec.js index cd9db95..c97ee95 100644 --- a/spec/metrics-spec.js +++ b/spec/metrics-spec.js @@ -703,6 +703,15 @@ describe('Metrics', () => { }) ) + describe('::sendTiming', () => + it('sets the gitHubUser', () => { + spyOn(store, 'setGitHubUser'); + const gitHubUser = 'beyonce' + reporterService.setGitHubUser(gitHubUser) + expect(store.setGitHubUser).toHaveBeenCalledWith(gitHubUser) + }) + ) + describe('::sendException', () => it('makes a request', () => { reporterService.sendException('desc') From 83dc864c134003c1aea8fa290d7b43aca0f2b103 Mon Sep 17 00:00:00 2001 From: Tilde Ann Thurium Date: Tue, 17 Jul 2018 13:51:01 -0700 Subject: [PATCH 2/5] rename function --- spec/metrics-spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/metrics-spec.js b/spec/metrics-spec.js index c97ee95..b6a4944 100644 --- a/spec/metrics-spec.js +++ b/spec/metrics-spec.js @@ -703,7 +703,7 @@ describe('Metrics', () => { }) ) - describe('::sendTiming', () => + describe('::setGitHubUser', () => it('sets the gitHubUser', () => { spyOn(store, 'setGitHubUser'); const gitHubUser = 'beyonce' From 5943b054800efffeea04ef27d90de91f03454675 Mon Sep 17 00:00:00 2001 From: Tilde Ann Thurium Date: Tue, 17 Jul 2018 13:52:03 -0700 Subject: [PATCH 3/5] :arrow_up: provideReporter version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 2a48894..16d2596 100644 --- a/package.json +++ b/package.json @@ -11,7 +11,7 @@ "providedServices": { "metrics-reporter": { "versions": { - "1.1.0": "provideReporter" + "1.2.0": "provideReporter" } } }, From 753512fd36f50d3fb55b434b924a7de718aa1491 Mon Sep 17 00:00:00 2001 From: Tilde Ann Thurium Date: Tue, 17 Jul 2018 14:09:56 -0700 Subject: [PATCH 4/5] update README.md --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 9014d70..64633e3 100644 --- a/README.md +++ b/README.md @@ -21,6 +21,7 @@ You will be asked at first-run whether you consent to telemetry being sent to th * Deprecated package names and versions * Chrome user-agent (version of Chrome, OS, CPU) * The number of non-core Atom packages that have been activated +* GitHub username, if a user has authenticated with the GitHub package This information is sent via [Google Analytics][GA] which allows the Atom team to analyze usage patterns and errors in order to help improve Atom. From 575db7eb6375ce58a728f154157d1669304537a2 Mon Sep 17 00:00:00 2001 From: Tilde Ann Thurium Date: Tue, 17 Jul 2018 14:16:56 -0700 Subject: [PATCH 5/5] :shirt: --- lib/reporter.js | 4 ++-- spec/metrics-spec.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/reporter.js b/lib/reporter.js index eff5f7e..6b004bb 100644 --- a/lib/reporter.js +++ b/lib/reporter.js @@ -126,8 +126,8 @@ class Reporter { this.send(params) } - static setGitHubUser(gitHubUser) { - this.getStore().setGitHubUser(gitHubUser); + static setGitHubUser (gitHubUser) { + this.getStore().setGitHubUser(gitHubUser) } // Private diff --git a/spec/metrics-spec.js b/spec/metrics-spec.js index b6a4944..49be4a1 100644 --- a/spec/metrics-spec.js +++ b/spec/metrics-spec.js @@ -705,7 +705,7 @@ describe('Metrics', () => { describe('::setGitHubUser', () => it('sets the gitHubUser', () => { - spyOn(store, 'setGitHubUser'); + spyOn(store, 'setGitHubUser') const gitHubUser = 'beyonce' reporterService.setGitHubUser(gitHubUser) expect(store.setGitHubUser).toHaveBeenCalledWith(gitHubUser)