Skip to content
This repository was archived by the owner on Dec 31, 2025. It is now read-only.
This repository was archived by the owner on Dec 31, 2025. It is now read-only.

Unify method for adding files to a pass #12

@aydenp

Description

@aydenp

Since #4 we have two ways to add files by Data (rather than one already on disk):

  • func addFile(named:,from:)
  • func addData(named:,from:)

The difference is that the first creates a temporary file on-disk, where the second does it entirely in memory. This is a workaround because the first doesn't support subdirectories (#6).

Ideally, only one of these should exist. Based on the outward appearance of the API, I would vote for the second which doesn't write to disk. This will also be important for #9, where these models may be reused.

Metadata

Metadata

Assignees

No one assigned

    Labels

    api breakingWill result in an API change that breaks existing usesenhancementNew feature or request

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions