tag class now badge and menu markup suggestions

[misiman]

Hi and thanks for sharing.

I found a couple of minor issues which you might not know about:

1. Bootstrap have resolved the Wordpress .tag class conflict which has now been replaced by .badge - see Rename .tag to .badge to avoid conflicting with WordPress twbs/bootstrap#21020
2. In bootstrap-menu.php, it appears that add_filter( 'wp_nav_menu_args', 'wp_bootstrap_nav_menu_args', 10, 2 ); is removing the .nav-link class from the markup.
3. In bootstrap-menu.php, some of the class outputs have leading or trailing spaces which need trimming before being added to the attributes array.
4. Bootstrap-menu.php is missing the for expanding/collapsing the mobile menu - maybe this is something you intentionally left out?

Hope this helps.

[rexblack]

Hey man, great! I really appreciate your findings. It's also very likely that i'll fix them soon as i use this plugin in recent projects.
For the meantime, you could stick to alpha.5

Currently every new alpha brings new changes (and that's of course desirable for a series of alpha), although lots of people are already using bs4. It's kind of hard to keep dependent work up to date. Hopefully the final release arrives soon...