From acc32f9f74e7174b86172bca9691c3eeecee9cd5 Mon Sep 17 00:00:00 2001 From: Sieluna Date: Wed, 14 Jan 2026 14:10:58 +0200 Subject: [PATCH 1/8] Update ci.yaml --- .github/workflows/ci.yaml | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 4b92a0d9..9e3b176f 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -30,7 +30,23 @@ jobs: uses: dtolnay/rust-toolchain@stable - name: Install dependencies - run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev libwayland-dev libxkbcommon-dev + run: | + sudo apt-get update + sudo apt-get install --no-install-recommends libasound2-dev libudev-dev libwayland-dev libxkbcommon-dev + + # Uninstall unneeded tools + # Haskell + sudo rm -rf /opt/ghc || true + sudo rm -rf /usr/local/.ghcup || true + # Android + sudo rm -rf /usr/local/lib/android + # Databases + sudo apt-get remove -y '^mongodb-.*' + sudo apt-get remove -y '^mysql-.*' + + # Clean up unused packages + sudo apt-get autoremove -y + sudo apt-get clean - name: Populate target directory from cache uses: Leafwing-Studios/cargo-cache@v2 From 5d0e331542d52d09c3f0a9ef0febafe1a8d81835 Mon Sep 17 00:00:00 2001 From: Sieluna Date: Wed, 14 Jan 2026 14:43:25 +0200 Subject: [PATCH 2/8] Make sure no error throw --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 9e3b176f..7f81d5f7 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -39,7 +39,7 @@ jobs: sudo rm -rf /opt/ghc || true sudo rm -rf /usr/local/.ghcup || true # Android - sudo rm -rf /usr/local/lib/android + sudo rm -rf /usr/local/lib/android || true # Databases sudo apt-get remove -y '^mongodb-.*' sudo apt-get remove -y '^mysql-.*' From dd98df8884214d98b0b76c2e083c016c6124d203 Mon Sep 17 00:00:00 2001 From: Sieluna Date: Wed, 14 Jan 2026 14:55:15 +0200 Subject: [PATCH 3/8] Try a more aggressive fix --- .github/workflows/ci.yaml | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 7f81d5f7..6cd7df68 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -35,14 +35,24 @@ jobs: sudo apt-get install --no-install-recommends libasound2-dev libudev-dev libwayland-dev libxkbcommon-dev # Uninstall unneeded tools + # .NET + sudo rm -rf /usr/share/dotnet || true + sudo apt-get remove -y '^aspnetcore-.*' || true + sudo apt-get remove -y '^dotnet-.*' --fix-missing || true # Haskell sudo rm -rf /opt/ghc || true sudo rm -rf /usr/local/.ghcup || true # Android sudo rm -rf /usr/local/lib/android || true - # Databases - sudo apt-get remove -y '^mongodb-.*' - sudo apt-get remove -y '^mysql-.*' + # PHP + sudo apt-get remove -y 'php.*' --fix-missing || true + # Database + sudo apt-get remove -y '^mongodb-.*' --fix-missing || true + sudo apt-get remove -y '^mysql-.*' --fix-missing || true + # Cloud + sudo apt-get remove -y azure-cli google-chrome-stable firefox powershell mono-devel libgl1-mesa-dri --fix-missing || true + sudo apt-get remove -y google-cloud-sdk --fix-missing || true + sudo apt-get remove -y google-cloud-cli --fix-missing || true # Clean up unused packages sudo apt-get autoremove -y From 71b966d23af1986bb42f579e31f2b7d7024e1982 Mon Sep 17 00:00:00 2001 From: Sieluna Date: Thu, 15 Jan 2026 01:37:52 +0200 Subject: [PATCH 4/8] Pass all checks --- Cargo.toml | 4 ++-- bevy_widgets/bevy_text_editing/src/char_position.rs | 2 +- bevy_widgets/bevy_toolbar/src/lib.rs | 9 ++------- crates/bevy_transform_gizmos/src/lib.rs | 9 ++------- 4 files changed, 7 insertions(+), 17 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 5479b4a1..c20dfbb3 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -39,8 +39,8 @@ serde = { version = "1", features = ["derive"] } tracing-test = "0.2.5" tracing = "0.1.41" atomicow = "1.1.0" -rfd = "0.15.3" -ron = "0.10.1" +rfd = "0.17.2" +ron = "0.12.0" variadics_please = "1.0" # local crates diff --git a/bevy_widgets/bevy_text_editing/src/char_position.rs b/bevy_widgets/bevy_text_editing/src/char_position.rs index c7d506fd..9ec4cebe 100644 --- a/bevy_widgets/bevy_text_editing/src/char_position.rs +++ b/bevy_widgets/bevy_text_editing/src/char_position.rs @@ -2,7 +2,7 @@ use bevy::prelude::*; /// A component that stores a character position in a text /// Separated from `usize` to make it clear that it is a character position, not a byte position. -/// And prevents accidental usage as a byte position in string[..`byte_position`] +/// And prevents accidental usage as a byte position in `string[..byte_position]` #[derive(Reflect, Default, Clone, Copy, Debug)] pub struct CharPosition(pub usize); diff --git a/bevy_widgets/bevy_toolbar/src/lib.rs b/bevy_widgets/bevy_toolbar/src/lib.rs index 1a44a524..82381248 100644 --- a/bevy_widgets/bevy_toolbar/src/lib.rs +++ b/bevy_widgets/bevy_toolbar/src/lib.rs @@ -42,9 +42,10 @@ pub struct ToolbarButton { } /// Available editor tools. -#[derive(Debug, Clone, Copy, PartialEq, Eq)] +#[derive(Debug, Default, Clone, Copy, PartialEq, Eq)] pub enum EditorTool { /// Selection tool for picking entities. + #[default] Select, /// Move tool for translating entities. Move, @@ -74,12 +75,6 @@ pub enum EditorTool { #[derive(Resource, Default)] pub struct ActiveTool(pub EditorTool); -impl Default for EditorTool { - fn default() -> Self { - Self::Select - } -} - /// Marker component for the gizmo mode status text. #[derive(Component)] pub struct GizmoModeStatus; diff --git a/crates/bevy_transform_gizmos/src/lib.rs b/crates/bevy_transform_gizmos/src/lib.rs index 5e127c8a..8efaa819 100644 --- a/crates/bevy_transform_gizmos/src/lib.rs +++ b/crates/bevy_transform_gizmos/src/lib.rs @@ -71,9 +71,10 @@ pub struct ScaleGizmo; pub struct InternalGizmoCamera; /// Available gizmo modes. -#[derive(Debug, Clone, Copy, PartialEq, Eq)] +#[derive(Debug, Default, Clone, Copy, PartialEq, Eq)] pub enum GizmoMode { /// Translation mode (W key). + #[default] Translate, /// Rotation mode (E key). Rotate, @@ -81,12 +82,6 @@ pub enum GizmoMode { Scale, } -impl Default for GizmoMode { - fn default() -> Self { - Self::Translate - } -} - /// Settings for the [`TransformGizmoPlugin`]. #[derive(Resource, Clone, Debug)] pub struct TransformGizmoSettings { From 3cb28534948b8ba2683288afd007769285f51e11 Mon Sep 17 00:00:00 2001 From: Sieluna Date: Thu, 15 Jan 2026 01:42:32 +0200 Subject: [PATCH 5/8] default config looks fine --- .github/workflows/ci.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 6cd7df68..c7934b44 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -59,9 +59,7 @@ jobs: sudo apt-get clean - name: Populate target directory from cache - uses: Leafwing-Studios/cargo-cache@v2 - with: - sweep-cache: true + uses: Swatinem/rust-cache@v2 - name: Run tests run: | From e6552c11ef892f2b66fee5b8d48c875fd4ffffb7 Mon Sep 17 00:00:00 2001 From: Sieluna Date: Thu, 15 Jan 2026 02:02:47 +0200 Subject: [PATCH 6/8] swatinem not cache worksapce, need rebuild everytime --- .github/workflows/ci.yaml | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index c7934b44..eff82530 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -63,9 +63,9 @@ jobs: - name: Run tests run: | - cargo test --locked --workspace --all-features --all-targets + cargo test --workspace --all-features --all-targets # Workaround for https://github.com/rust-lang/cargo/issues/6669 - cargo test --locked --workspace --all-features --doc + cargo test --workspace --all-features --doc # Run clippy lints. clippy: @@ -85,12 +85,10 @@ jobs: run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev libwayland-dev libxkbcommon-dev - name: Populate target directory from cache - uses: Leafwing-Studios/cargo-cache@v2 - with: - sweep-cache: true + uses: Swatinem/rust-cache@v2 - name: Run clippy lints - run: cargo clippy --locked --workspace --all-targets --all-features -- --deny warnings + run: cargo clippy --workspace --all-targets --all-features -- --deny warnings # Check formatting. format: @@ -142,12 +140,10 @@ jobs: run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev libwayland-dev libxkbcommon-dev - name: Populate target directory from cache - uses: Leafwing-Studios/cargo-cache@v2 - with: - sweep-cache: true + uses: Swatinem/rust-cache@v2 - name: Check documentation - run: cargo doc --locked --workspace --all-features --document-private-items --no-deps + run: cargo doc --workspace --all-features --document-private-items --no-deps # Check design book. book: From f7bdf6a3a81014bab158919fd0e8aa71cf364eae Mon Sep 17 00:00:00 2001 From: Sieluna Date: Thu, 15 Jan 2026 02:11:10 +0200 Subject: [PATCH 7/8] Revert "swatinem not cache worksapce, need rebuild everytime" This reverts commit e6552c11ef892f2b66fee5b8d48c875fd4ffffb7. --- .github/workflows/ci.yaml | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index eff82530..c7934b44 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -63,9 +63,9 @@ jobs: - name: Run tests run: | - cargo test --workspace --all-features --all-targets + cargo test --locked --workspace --all-features --all-targets # Workaround for https://github.com/rust-lang/cargo/issues/6669 - cargo test --workspace --all-features --doc + cargo test --locked --workspace --all-features --doc # Run clippy lints. clippy: @@ -85,10 +85,12 @@ jobs: run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev libwayland-dev libxkbcommon-dev - name: Populate target directory from cache - uses: Swatinem/rust-cache@v2 + uses: Leafwing-Studios/cargo-cache@v2 + with: + sweep-cache: true - name: Run clippy lints - run: cargo clippy --workspace --all-targets --all-features -- --deny warnings + run: cargo clippy --locked --workspace --all-targets --all-features -- --deny warnings # Check formatting. format: @@ -140,10 +142,12 @@ jobs: run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev libwayland-dev libxkbcommon-dev - name: Populate target directory from cache - uses: Swatinem/rust-cache@v2 + uses: Leafwing-Studios/cargo-cache@v2 + with: + sweep-cache: true - name: Check documentation - run: cargo doc --workspace --all-features --document-private-items --no-deps + run: cargo doc --locked --workspace --all-features --document-private-items --no-deps # Check design book. book: From 59b73249ea501654713e5708abeeab2c0495c156 Mon Sep 17 00:00:00 2001 From: Sieluna Date: Thu, 15 Jan 2026 02:11:18 +0200 Subject: [PATCH 8/8] Revert "default config looks fine" This reverts commit 3cb28534948b8ba2683288afd007769285f51e11. --- .github/workflows/ci.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index c7934b44..6cd7df68 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -59,7 +59,9 @@ jobs: sudo apt-get clean - name: Populate target directory from cache - uses: Swatinem/rust-cache@v2 + uses: Leafwing-Studios/cargo-cache@v2 + with: + sweep-cache: true - name: Run tests run: |