From a440965abf25573424a3b3669567544035303c9c Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 18 Nov 2025 17:50:26 +0000 Subject: [PATCH 1/2] Initial plan From 901819f2b5a272e9d9210a5968afb5579dd578b7 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 18 Nov 2025 17:59:30 +0000 Subject: [PATCH 2/2] Apply pattern matching for instanceof (Java 17 feature) Co-authored-by: ChristianHoesel <4498707+ChristianHoesel@users.noreply.github.com> --- src/main/java/com/bitctrl/resource/Configuration.java | 4 ++-- src/main/java/com/bitctrl/rmi/RemoteTools.java | 2 +- src/main/java/com/bitctrl/util/TreeProperties.java | 4 ++-- src/main/java/com/bitctrl/util/monitor/SubMonitor.java | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/main/java/com/bitctrl/resource/Configuration.java b/src/main/java/com/bitctrl/resource/Configuration.java index 06dba96..3227805 100644 --- a/src/main/java/com/bitctrl/resource/Configuration.java +++ b/src/main/java/com/bitctrl/resource/Configuration.java @@ -274,8 +274,8 @@ public Set stringPropertyNames() { final Set keys = new HashSet<>(); for (final Object key : configuration.keySet()) { - if (key instanceof String) { - keys.add((String) key); + if (key instanceof final String stringKey) { + keys.add(stringKey); } } return keys; diff --git a/src/main/java/com/bitctrl/rmi/RemoteTools.java b/src/main/java/com/bitctrl/rmi/RemoteTools.java index 84f3d6d..e01de94 100644 --- a/src/main/java/com/bitctrl/rmi/RemoteTools.java +++ b/src/main/java/com/bitctrl/rmi/RemoteTools.java @@ -87,7 +87,7 @@ public static void init(final StoppableApplication application, final String[] a } catch (final NotBoundException ex) { throw new IllegalStateException(ex); } catch (final UnmarshalException ex) { - if (ex.getCause() instanceof SocketException) { + if (ex.getCause() instanceof final SocketException socketEx) { // Verbindungsabruch, weil Applikation beendet wurde System.exit(0); } else { diff --git a/src/main/java/com/bitctrl/util/TreeProperties.java b/src/main/java/com/bitctrl/util/TreeProperties.java index a239555..299a634 100644 --- a/src/main/java/com/bitctrl/util/TreeProperties.java +++ b/src/main/java/com/bitctrl/util/TreeProperties.java @@ -528,8 +528,8 @@ public Set stringPropertyNames() { final Set keys = new HashSet<>(); for (final Object key : keySet()) { - if (key instanceof String) { - keys.add((String) key); + if (key instanceof final String stringKey) { + keys.add(stringKey); } } return keys; diff --git a/src/main/java/com/bitctrl/util/monitor/SubMonitor.java b/src/main/java/com/bitctrl/util/monitor/SubMonitor.java index 1d0bdbc..82495b6 100644 --- a/src/main/java/com/bitctrl/util/monitor/SubMonitor.java +++ b/src/main/java/com/bitctrl/util/monitor/SubMonitor.java @@ -504,9 +504,9 @@ public static SubMonitor convert(IMonitor monitor, final String taskName, final // Optimization: if the given monitor already a SubMonitor, no // conversion is necessary - if (monitor instanceof SubMonitor) { - monitor.beginTask(taskName, work); - return (SubMonitor) monitor; + if (monitor instanceof final SubMonitor subMonitor) { + subMonitor.beginTask(taskName, work); + return subMonitor; } monitor.beginTask(taskName, MINIMUM_RESOLUTION);