allow DOMParser to be passed in

[derhuerst]

It would be nice to be able to pass DOMParser into parse. Right now, I have to mutate global in Node.js in order to be able to use this library.

[derhuerst]

Also, I noticed that vdom-parser implicitly relies on document to exist. Like with window.DOMParser, taking it as an optional parameter would be better.

Otherwise requiring global might be a good solution.

[bitinn]

This package is intended for client side, you might want vdom-to-html? (From my phone)

…

在 2017年2月9日，05:32，Jannis Redmann ***@***.***> 写道： Also, I noticed that vdom-parser implicitly relies on document to exist. Like with window.DOMParser, taking it as an optional parameter would be better. Also, requiring global might be a good solution. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[derhuerst]

Nevertheless, it's a nice design goal to have isomorphic modules that both in the Browser and in Node. This makes Server-side rendering, tests and automation easier. This is why the global module has been made.

Taking in an opt parameter wouldn't that of a problem right?

I tried vdom-to-html afterwards and it works fine, but I also want other devs not to have to dig into all available modules.