-
Notifications
You must be signed in to change notification settings - Fork 16
Description
The field “formats” in the JSON contains the keys for the formats. The keys are language dependent, and so it is reasonable to edit out the ones that haven’t been translated. But why does “formats_shared_id_list”, which is information that is not language dependent, also edit out the untranslated formats? If it contained all formats, then it would give crouton the chance to look up the format in another language, or even just to add an “some formats have not been translated” message.
Let's consider a specific example. Suppose there is a format O2 for "open for non-addicts the second week of the month" that on the given server is defined in German but not English. If a meeting has format O2 plus some others that do have English versions, if I'm editing with English as the selected language, indeed, the list of formats I see in the editing pane will only show the formats with English versions and will omit O2. If I edit the formats and save, in the old UI it will save only the formats that were visible, and drop O2. In the new UI it saves my edits but keeps the invisible O2 format (which seems better but still not ideal).
There are various ways we could change the server API and the UI so that O2 would be visible even when editing in English. One would be to make every format visible in every language -- if it's not available in the current language, either show the English version if available, or if not in any available language, in either case along with a note that it hasn't been translated. (This is analogous to the approach the format editor takes in the new UI.) Or there are other possibilities as well but they don't seem as good.