From a9ee5ffc1922089eb45d96c02496cf40bb2a9262 Mon Sep 17 00:00:00 2001 From: Nick Mitchell Date: Wed, 26 Mar 2025 13:07:50 -0400 Subject: [PATCH 1/3] Fix the `ls` help syntax to denote org name should be used, not ID --- pkg/cmd/ls/ls.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/cmd/ls/ls.go b/pkg/cmd/ls/ls.go index f10eb269..46d51e71 100644 --- a/pkg/cmd/ls/ls.go +++ b/pkg/cmd/ls/ls.go @@ -47,7 +47,7 @@ func NewCmdLs(t *terminal.Terminal, loginLsStore LsStore, noLoginLsStore LsStore Example: ` brev ls brev ls orgs - brev ls --org + brev ls --org `, PersistentPostRunE: func(cmd *cobra.Command, args []string) error { if hello.ShouldWeRunOnboardingLSStep(noLoginLsStore) && hello.ShouldWeRunOnboarding(noLoginLsStore) { From 2e08cc077fd8c92ebdbb6df586b158ff389824cf Mon Sep 17 00:00:00 2001 From: Nick Mitchell Date: Mon, 31 Mar 2025 15:19:29 -0400 Subject: [PATCH 2/3] Fix CI --- .github/workflows/fmt.yml | 2 +- .github/workflows/lint.yml | 2 +- .github/workflows/test.yml | 2 +- .github/workflows/vet.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/fmt.yml b/.github/workflows/fmt.yml index 344842e6..89e3c0b9 100644 --- a/.github/workflows/fmt.yml +++ b/.github/workflows/fmt.yml @@ -27,7 +27,7 @@ jobs: - name: install - run: make install + run: make install-tools - name: check fmt run: make fmtcheck # - name: Report Status diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 4c12d2d0..e5310ce0 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -25,7 +25,7 @@ jobs: go-version: '1.22.6' cache: true - name: install - run: make install + run: make install-tools - name: lint run: make lint # - name: Report Status diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index c99817d8..632dd61c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -25,7 +25,7 @@ jobs: go-version: '1.22.6' cache: true - name: install - run: make install + run: make install-tools - name: test run: make test - name: Upload coverage diff --git a/.github/workflows/vet.yml b/.github/workflows/vet.yml index 0a69f7e1..8c61c54f 100644 --- a/.github/workflows/vet.yml +++ b/.github/workflows/vet.yml @@ -25,7 +25,7 @@ jobs: go-version: '1.22.6' cache: true - name: install - run: make install + run: make install-tools - name: vet run: make vet # - name: Report Status From 752a74ff05ac2470b56281b42285ccf970470126 Mon Sep 17 00:00:00 2001 From: Nick Mitchell Date: Mon, 31 Mar 2025 15:22:24 -0400 Subject: [PATCH 3/3] Update upload-artifact to v4 --- .github/workflows/legacy.yml | 4 ++-- .github/workflows/test.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/legacy.yml b/.github/workflows/legacy.yml index eca7a421..4f1a9c14 100644 --- a/.github/workflows/legacy.yml +++ b/.github/workflows/legacy.yml @@ -27,13 +27,13 @@ jobs: - name: Build run: make ci - name: Upload coverage - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: coverage path: coverage.* - name: Upload dist - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: dist path: dist diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 632dd61c..0d4a13d0 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -29,13 +29,13 @@ jobs: - name: test run: make test - name: Upload coverage - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: coverage path: coverage.* - name: Upload dist - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: dist path: dist