Skip to content

Commit 946a966

Browse files
committed
Fixed regexp escaping and added tests
1 parent a3ec2ea commit 946a966

File tree

1 file changed

+23
-8
lines changed

1 file changed

+23
-8
lines changed

spec/unit/client_spec.rb

Lines changed: 23 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -232,19 +232,34 @@ module Proxy
232232
client.remap_dns_hosts(DOMAIN => '1.2.3.4')
233233
end
234234

235-
it 'sets a rewrite rule' do
236-
resource['rewrite'].should_receive(:put).
237-
with(:matchRegex => 'old.com', :replace => 'new.com')
235+
describe 'rewrite rules' do
238236

239-
client.rewrite(%r[old.com], 'new.com')
240-
end
237+
context 'when using a regular expression' do
238+
it 'sets a rewrite rule' do
239+
resource['rewrite'].should_receive(:put).
240+
with(:matchRegex => 'old\.com', :replace => 'new.com')
241+
242+
client.rewrite('old\.com', 'new.com')
243+
end
244+
end
245+
246+
context 'when using a string' do
247+
it 'sets a rewrite rule' do
248+
resource['rewrite'].should_receive(:put).
249+
with(:matchRegex => 'old\.com', :replace => 'new.com')
241250

242-
it 'clears the rewrite rules' do
243-
resource['rewrite'].should_receive(:delete)
251+
client.rewrite(%r{old\.com}, 'new.com')
252+
end
253+
end
254+
255+
it 'clears the rewrite rules' do
256+
resource['rewrite'].should_receive(:delete)
244257

245-
client.clear_rewrites
258+
client.clear_rewrites
259+
end
246260
end
247261

262+
248263
context "#selenium_proxy" do
249264
it "defaults to HTTP proxy only" do
250265
proxy = client.selenium_proxy

0 commit comments

Comments
 (0)