Actions do not upload source release

[tammojan]

The new scikit-build-wheel based build system now automatically uploads wheels for new releases to pypi. We forgot that it also should upload a source release.

(I created a source release for 3.6.1 manually from the tag and uploaded it to pypi.)

[gmloose]

We did not forget, but it somehow failed to do so. We do build a tar ball, and it should have been uploaded as part of the upload_pypi job in .github/workflows/build_release.yml. Or is it maybe related to the fact that the publish action by the CI pipeline failed the first time due to missing credentials?

[badshah400]

Source tarballs are similarly missing from PyPI for version 3.7.1 too. Just realised when trying to update the openSUSE RPM package for python-casacore.

[gmloose]

Maybe the root cause of this issue is the (ab)use of overwrite: true in the Upload wheels step of the build_wheels job. The comment suggests this is needed to work around the fact that we do not yet use setuptools_scm to generate unique version numbers. However, the documentation of the migration guide for the action download-artifact states that if you wish to overwrite an existing artifact, you must use this option. But we do not want to overwrite the previous artifact (which happens to be our source tar ball), we like it to co-exist with the other artifacts (our binary wheels).

[tammojan]

I uploaded the source tarball for v3.7.1 manually now.

[gmloose]

Fixed by #283