From f0237152bbc88370ef9b4cc4d27bfc251a135ca1 Mon Sep 17 00:00:00 2001 From: Ido Ben-Natan Date: Fri, 16 May 2014 22:00:52 +0300 Subject: [PATCH 1/2] error was lowercase instead of upper case --- www/js/openfb-angular.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/js/openfb-angular.js b/www/js/openfb-angular.js index b076ec0..0ae2b9c 100644 --- a/www/js/openfb-angular.js +++ b/www/js/openfb-angular.js @@ -55,7 +55,7 @@ angular.module('openfb', []) function login(fbScope) { if (!fbAppId) { - return error({error: 'Facebook App Id not set.'}); + return Error({error: 'Facebook App Id not set.'}); } var loginWindow; From e61ba185b5b1f4fcf836ef627752ad6d10cb1d3e Mon Sep 17 00:00:00 2001 From: Ido Ben-Natan Date: Fri, 16 May 2014 22:01:49 +0300 Subject: [PATCH 2/2] facebook gave an error about popup --- www/js/openfb-angular.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/js/openfb-angular.js b/www/js/openfb-angular.js index 0ae2b9c..1f9c31c 100644 --- a/www/js/openfb-angular.js +++ b/www/js/openfb-angular.js @@ -84,7 +84,7 @@ angular.module('openfb', []) } loginWindow = window.open(FB_LOGIN_URL + '?client_id=' + fbAppId + '&redirect_uri=' + oauthRedirectURL + - '&response_type=token&display=popup&scope=' + fbScope, '_blank', 'location=no'); + '&response_type=token&scope=' + fbScope, '_blank', 'location=no'); // If the app is running in Cordova, listen to URL changes in the InAppBrowser until we get a URL with an access_token or an error if (runningInCordova) {