Skip to content

Applying github-review-approve with no comments fails #92

@stsquad

Description

@stsquad

I can't quite follow the logic of github-review-submit-review but I can't see it calling either github-review-post-review-replies or github-review-post-review when I haven't added any additional comments and I just want to approve the PR. Some modest instrumenting of the two legs and I see:

Submitting review, this may take a while ...
ghr-prr: t nil
ghr-rpr: nil nil

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions