Skip to content

Stop requiring d3 in ChartwerkPod constructor #1

@jonyrock

Description

@jonyrock

As comment says in https://github.com/chartwerk/base/blob/master/src/index.ts,

abstract class ChartwerkPod<T extends TimeSerie, O extends Options> {
// ...
  constructor(
    // maybe it's not the best idea
    protected _d3: typeof d3, 
    el: HTMLElement,
// ...
  ) {

it's not the best idea, but not "maybe". Why do you really need this d3 param?

Is it because you can't compile lib otherwise? Well, I think it doable....

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions