#37: Deprecate Manifest(Reader) and update all related

Implemenation does not properly map characters to map and makes assumptions about character encoding which might lead to failures.
Deprecate and rely on Java Manifest reader to do the right thing.

This closes #37

Author: michael-o

src/main/java/org/codehaus/plexus/archiver/jar/Manifest.java

@@ -780,7 +780,10 @@ private void setManifestVersion()
      * @throws ManifestException if the manifest is not valid according
      *                           to the JAR spec
      * @throws IOException       if the manifest cannot be read from the reader.
+     * @deprecated This constructor does not properly map characters to bytes. Use
+     *            {@link #Manifest(InputStream)}. Will be removed in 4.0.
      */
+    @Deprecated
     public Manifest( Reader r )
         throws ManifestException, IOException
     {
@@ -937,6 +940,7 @@ public ExistingSection getSection( String name )
     }
 
 
+    @Deprecated
     private static InputStream getInputStream( Reader r )
         throws IOException
     {

src/test/java/org/codehaus/plexus/archiver/jar/ManifestTest.java

@@ -17,8 +17,9 @@
  *
  */
 
-import java.io.FileReader;
+import java.io.FileInputStream;
 import java.io.IOException;
+import java.io.InputStream;
 import java.io.PrintWriter;
 import java.io.StringWriter;
 import java.util.jar.Attributes;
@@ -31,15 +32,15 @@
 public class ManifestTest
     extends PlexusTestCase
 {
-    public void testManifestReader1()
+    public void testManifest1()
         throws Exception
     {
         Manifest manifest = getManifest( "src/test/resources/manifests/manifest1.mf" );
         String version = manifest.getManifestVersion();
         assertEquals( "Manifest was not created with correct version - ", "1.0", version );
     }
 
-    public void testManifestReader2()
+    public void testManifest2()
         throws Exception
     {
         try
@@ -52,7 +53,7 @@ public void testManifestReader2()
         }
     }
 
-    public void testManifestReader3()
+    public void testManifest3()
         throws Exception
     {
         try
@@ -65,7 +66,7 @@ public void testManifestReader3()
         }
     }
 
-    public void testManifestReader5()
+    public void testManifest5()
         throws Exception
     {
         try
@@ -321,15 +322,15 @@ public void testAddConfiguredSectionPlexusManifest()
     private Manifest getManifest( String filename )
         throws IOException, ManifestException
     {
-        FileReader r = new FileReader( getTestFile( filename ) );
+        InputStream is = new FileInputStream( getTestFile( filename ) );
 
         try
         {
-            return new Manifest( r );
+            return new Manifest( is );
         }
         finally
         {
-            r.close();
+            is.close();
         }
     }