Error when loading with irb: "uninitialized constant Coinbase (NameError)"

[Makazone]

Description

It appears that the top-level module Coinbase is not defined before the first require_relative 'coinbase/client'. The code in api_client.rb defines module Coinbase::Client. This causes Ruby to fail when trying to access Coinbase::Client because Ruby doesn’t recognize the Coinbase module yet.

To reproduce (using ruby 2.7.5 and 3+):

1. Launch IRB.
2. Run require 'coinbase'
3. Observe the "uninitialized constant Coinbase (NameError)" error.

Will submit a PR with a suggested fix!

[Makazone]

Looks like I don't have enough permissions to push a branch with a fix.

Here is how I'm thinking about it:

1. The first require_relative 'coinbase/client' references lib/coinbase/client/api_client.rb
2. The file defines module Coinbase::Client and since no module Coinbase was defined before the error appears
3. The fix is to update api_client.rb with

module Coinbase
  module Client
    class ApiClient

[Makazone]

@alex-stone let me know how I can help further here. I've tested the fix locally (with make test and using it with irb) and it looks good. I'm also seeing that other files follow the same syntax (module Coinbase module XXX instead of module Coinbase::XXX).

[dwkns]

Having the same problem here too.

And can confirm that @Makazone's fix seems to work locally.