Should we use GuestRegionCollection?

[MatiasVara]

Based on rust-vmm/vm-memory#312, I think we can replace

libkrun/src/vmm/src/linux/vstate.rs

Line 502 in 714e762

pub guest_memfds: Vec<(Range<u64>, RawFd)>,

by using GuestRegionCollection by doing something like:

 struct MockRegion {
        range: Range<u64>,
        fd: RawFd,
    }
...
pub guest_memfds: GuestRegionCollection<MockRegion>;

do you think it would be worth to do it?

Thanks,

[jakecorrenti]

I personally don't see an issue with it. I think it results in easier to read code and it's "free".

Will the fact that those commits aren't in a release yet cause any issues on our side?

[MatiasVara]

I personally don't see an issue with it. I think it results in easier to read code and it's "free".

Will the fact that those commits aren't in a release yet cause any issues on our side?

I tried to start but I just figured that they are not in last release. I guess I will wait until the next release.