refactor: CImg, CMedia: rename blankColor prop to placeholderColor

woothu · woothu · commit 542807d7541f · 2019-10-16T12:57:55.000+02:00
diff --git a/src/components/Image/CImg.vue b/src/components/Image/CImg.vue
@@ -12,7 +12,7 @@
     :class="imageClasses"
     :width="width"
     :height="height"
-    :style="{'background-color': isActive ? blankColor : 'transparent' }"
+    :style="{'background-color': isActive ? placeholderColor : 'transparent' }"
   />
 </template>
 
@@ -47,7 +47,7 @@ export default {
       type: String,
       validator: align => ['', 'left', 'right', 'center'].includes(align)
     },
-    blankColor: {
+    placeholderColor: {
       type: String,
       default: 'transparent'
     }
diff --git a/src/components/Image/tests/CImg.spec.js b/src/components/Image/tests/CImg.spec.js
@@ -14,8 +14,7 @@ const customWrapper = mount(Component, {
     rounded: 'right',
     // thumbnail: true,
     align: 'right',
-    blankColor: 'red',
-    rounded: 'right'
+    placeholderColor: 'red'
   }
 })
 
diff --git a/src/components/Image/tests/CImgLazy.spec.js b/src/components/Image/tests/CImgLazy.spec.js
@@ -24,7 +24,7 @@ const customWrapper = mount(Component, {
     rounded: 'right',
     // thumbnail: true,
     align: 'right',
-    blankColor: 'red'
+    placeholderColor: 'red'
   }
 })
 
diff --git a/src/components/Media/CMedia.vue b/src/components/Media/CMedia.vue
@@ -37,7 +37,7 @@ export default {
     computedAsideImageProps () {
       return Object.assign(
         {
-          blankColor: '#777777',
+          placeholderColor: '#777777',
           width: '64px',
           height: this.asideVerticalPosition === 'stretch' ? '100%' : '64px'
         },
diff --git a/src/components/index.d.ts b/src/components/index.d.ts
@@ -315,7 +315,7 @@ export declare class CImg extends Vue {
   rounded: [boolean, string]
   thumbnail: boolean
   align: string
-  blankColor: string
+  placeholderColor: string
 }
 
 export declare class CImgLazy extends CImg {

Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,7 @@ const customWrapper = mount(Component, {`
`14`	`14`	`rounded: 'right',`
`15`	`15`	`// thumbnail: true,`
`16`	`16`	`align: 'right',`
`17`		`- blankColor: 'red',`
`18`		`- rounded: 'right'`
	`17`	`+ placeholderColor: 'red'`
`19`	`18`	`}`
`20`	`19`	`})`
`21`	`20`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ const customWrapper = mount(Component, {`
`24`	`24`	`rounded: 'right',`
`25`	`25`	`// thumbnail: true,`
`26`	`26`	`align: 'right',`
`27`		`- blankColor: 'red'`
	`27`	`+ placeholderColor: 'red'`
`28`	`28`	`}`
`29`	`29`	`})`
`30`	`30`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ export default {`
`37`	`37`	`computedAsideImageProps () {`
`38`	`38`	`return Object.assign(`
`39`	`39`	`{`
`40`		`- blankColor: '#777777',`
	`40`	`+ placeholderColor: '#777777',`
`41`	`41`	`width: '64px',`
`42`	`42`	`height: this.asideVerticalPosition === 'stretch' ? '100%' : '64px'`
`43`	`43`	`},`
Original file line number	Diff line number	Diff line change
`@@ -315,7 +315,7 @@ export declare class CImg extends Vue {`
`315`	`315`	`rounded: [boolean, string]`
`316`	`316`	`thumbnail: boolean`
`317`	`317`	`align: string`
`318`		`- blankColor: string`
	`318`	`+ placeholderColor: string`
`319`	`319`	`}`
`320`	`320`
`321`	`321`	`export declare class CImgLazy extends CImg {`