From 9abac6a31caa71e65a76bbc82e38fc1db61b341e Mon Sep 17 00:00:00 2001 From: Alex Severin Date: Sun, 29 Jun 2025 22:40:34 +0300 Subject: [PATCH 1/9] update kani --- .github/workflows/safety.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/safety.yml b/.github/workflows/safety.yml index be1ef5c..0bc2261 100644 --- a/.github/workflows/safety.yml +++ b/.github/workflows/safety.yml @@ -84,4 +84,5 @@ jobs: timeout-minutes: 220 uses: model-checking/kani-github-action@v1 with: - kani-version: '0.54.0' + kani-version: '0.63.0' + args: --fail-fast From 7a61f8dfc2526a854c96cad0ac3ebcc8db29a481 Mon Sep 17 00:00:00 2001 From: Alex Severin Date: Sun, 29 Jun 2025 23:06:49 +0300 Subject: [PATCH 2/9] fix clippy --- src/utils/arbitrary.rs | 2 +- tests/comparison.rs | 4 ++-- tests/neon.rs | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/utils/arbitrary.rs b/src/utils/arbitrary.rs index 4e785a5..6b4e165 100644 --- a/src/utils/arbitrary.rs +++ b/src/utils/arbitrary.rs @@ -11,7 +11,7 @@ use proptest::sample::SizeRange; type Mat = MatBase, T>; impl Mat { - pub fn to_ref(&self) -> MatRef { + pub fn to_ref<'a>(&'a self) -> MatRef<'a, T> { MatRef::from_parts( self.nrows(), self.ncols(), diff --git a/tests/comparison.rs b/tests/comparison.rs index 70de0d5..3c73d85 100644 --- a/tests/comparison.rs +++ b/tests/comparison.rs @@ -25,7 +25,7 @@ fn bench_aarch64_f32() { let t_neon = display_duration(time_with(&neon_kernel, n, TRIES)); let t_faer = display_duration(time_with(&faer_kernel, n, TRIES)); let t_mt = display_duration(time_with(&mt_kernel, n, TRIES)); - println!("{0:>4} {1:>14} {2:>14} {3:>14}", n, t_neon, t_faer, t_mt); + println!("{n:>4} {t_neon:>14} {t_faer:>14} {t_mt:>14}"); } } @@ -49,7 +49,7 @@ fn display_duration(t: Duration) -> String { format!("{}.{}{}", num.trunc(), fract, unit) } }; - let s = format!("{:?}", t); + let s = format!("{t:?}"); if s.contains("ms") { pretty(s, "ms") diff --git a/tests/neon.rs b/tests/neon.rs index 1b6afc3..284dc70 100644 --- a/tests/neon.rs +++ b/tests/neon.rs @@ -93,6 +93,6 @@ impl<'a> TestCase<'a> { param.pack_sizes, &mut packing_buf, ); - assert_eq!(actual.as_slice(), param.expect, "{:?}", self); + assert_eq!(actual.as_slice(), param.expect, "{self:?}"); } } From e8b9b92463e01ff43f0a1c42ec16daec0a5d4748 Mon Sep 17 00:00:00 2001 From: Alex Severin Date: Mon, 30 Jun 2025 00:01:30 +0300 Subject: [PATCH 3/9] draft for minimal lockfile --- .github/workflows/check.yml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index a34c803..7fb7855 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -45,8 +45,7 @@ jobs: strategy: fail-fast: false matrix: - # Get early warning of new lints which are regularly introduced in beta channels. - toolchain: [stable, beta] + toolchain: [nightly-2025-06-29] steps: - uses: actions/checkout@v4 with: @@ -56,6 +55,8 @@ jobs: with: toolchain: ${{ matrix.toolchain }} components: clippy + - name: cargo --version + run: cargo clippy --version - name: cargo clippy run: cargo clippy --all-targets --all-features env: @@ -106,12 +107,20 @@ jobs: - uses: actions/checkout@v4 with: submodules: true + # - name: Install nightly + # uses: dtolnay/rust-toolchain@master + # with: + # toolchain: nightly + # - name: Generate minimal lockfile + # run: cargo generate-lockfile -Z minimal-versions - name: Install ${{ matrix.msrv }} uses: dtolnay/rust-toolchain@master with: toolchain: ${{ matrix.msrv }} - name: cargo +${{ matrix.msrv }} check - run: cargo check + run: + rustc --version + cargo check env: RUSTFLAGS: -D warnings semver: From 76f06b7d8f8a79abd3863497df6e24251056c7d1 Mon Sep 17 00:00:00 2001 From: Alex Severin Date: Mon, 30 Jun 2025 00:03:57 +0300 Subject: [PATCH 4/9] fix multiline string --- .github/workflows/check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 7fb7855..dbb7b26 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -118,7 +118,7 @@ jobs: with: toolchain: ${{ matrix.msrv }} - name: cargo +${{ matrix.msrv }} check - run: + run: | rustc --version cargo check env: From 50f3675066e3bb82d937da4c340abe2d00f76ee6 Mon Sep 17 00:00:00 2001 From: Alex Severin Date: Mon, 30 Jun 2025 00:08:59 +0300 Subject: [PATCH 5/9] generate minimal lockfile for msrv --- .github/workflows/check.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index dbb7b26..9ec0a48 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -107,12 +107,12 @@ jobs: - uses: actions/checkout@v4 with: submodules: true - # - name: Install nightly - # uses: dtolnay/rust-toolchain@master - # with: - # toolchain: nightly - # - name: Generate minimal lockfile - # run: cargo generate-lockfile -Z minimal-versions + - name: Install nightly + uses: dtolnay/rust-toolchain@master + with: + toolchain: nightly + - name: Generate minimal lockfile + run: cargo generate-lockfile -Z minimal-versions - name: Install ${{ matrix.msrv }} uses: dtolnay/rust-toolchain@master with: From 7c445b554598843d931a56c9a939a94a6320d5ad Mon Sep 17 00:00:00 2001 From: Alex Severin Date: Mon, 30 Jun 2025 00:13:02 +0300 Subject: [PATCH 6/9] sep rustc print --- .github/workflows/check.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 9ec0a48..67e99db 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -117,10 +117,10 @@ jobs: uses: dtolnay/rust-toolchain@master with: toolchain: ${{ matrix.msrv }} + - name: rustc --version + run: rustc --version - name: cargo +${{ matrix.msrv }} check - run: | - rustc --version - cargo check + run: cargo check env: RUSTFLAGS: -D warnings semver: From d91e36e271920295275833725638794888d0e70e Mon Sep 17 00:00:00 2001 From: Alex Severin Date: Mon, 30 Jun 2025 00:14:45 +0300 Subject: [PATCH 7/9] rename command for clippy version --- .github/workflows/check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 67e99db..87ab2f9 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -55,7 +55,7 @@ jobs: with: toolchain: ${{ matrix.toolchain }} components: clippy - - name: cargo --version + - name: cargo clippy --version run: cargo clippy --version - name: cargo clippy run: cargo clippy --all-targets --all-features From c2692ec960e3ffcfb5c8c63c61179971829c5066 Mon Sep 17 00:00:00 2001 From: Alex Severin Date: Mon, 30 Jun 2025 00:16:35 +0300 Subject: [PATCH 8/9] rm dublicate lines in ci --- .github/workflows/check.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 87ab2f9..ab7fd81 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -55,8 +55,7 @@ jobs: with: toolchain: ${{ matrix.toolchain }} components: clippy - - name: cargo clippy --version - run: cargo clippy --version + - run: cargo clippy --version - name: cargo clippy run: cargo clippy --all-targets --all-features env: @@ -117,8 +116,7 @@ jobs: uses: dtolnay/rust-toolchain@master with: toolchain: ${{ matrix.msrv }} - - name: rustc --version - run: rustc --version + - run: rustc --version - name: cargo +${{ matrix.msrv }} check run: cargo check env: From 45d5b93676fd7015816b0174f728279319dccfb5 Mon Sep 17 00:00:00 2001 From: Alex Severin Date: Mon, 30 Jun 2025 00:25:16 +0300 Subject: [PATCH 9/9] pin actionlint --- .github/workflows/actionlint.yml | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml index 0f0c455..f1ac0d7 100644 --- a/.github/workflows/actionlint.yml +++ b/.github/workflows/actionlint.yml @@ -1,15 +1,20 @@ -name: Lint GitHub Actions workflows -on: [push, pull_request] +name: actionlint + +on: + push: + branches: [main, master] + pull_request: + +# If new code is pushed to a PR branch, then cancel in progress workflows for that PR. Ensures that +# we don't waste CI time +concurrency: + group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} + cancel-in-progress: true jobs: actionlint: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v4 - - name: Download actionlint - id: get_actionlint - run: bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash) - shell: bash - - name: Check workflow files - run: ${{ steps.get_actionlint.outputs.executable }} -color - shell: bash + - name: actionlint + uses: raven-actions/actionlint@v2.0.1