From 1e9dde75fa504ee7c4611bde3e04a53325ac629f Mon Sep 17 00:00:00 2001 From: Pawel Date: Wed, 3 Dec 2025 10:19:20 +0000 Subject: [PATCH 1/2] Fix views made with whitespace-only names --- lib/GADS/View.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/GADS/View.pm b/lib/GADS/View.pm index 694a3cf6e..8cea6865c 100644 --- a/lib/GADS/View.pm +++ b/lib/GADS/View.pm @@ -338,6 +338,10 @@ sub write length $self->name < 128 or error __"View name must be less than 128 characters"; + # Names consisting of just whitespace characters cause issues when displaying a view + $self->name !~ /^\s*$/ + or error __"View name must not contain whitespace characters"; + my $global = !$self->layout->user ? 1 : $self->global; $self->clear_writable; # Force rebuild based on any updated values From 1f7962e3f3cb32057a8a5a31fe54d1cd826a4ae3 Mon Sep 17 00:00:00 2001 From: Pawel Date: Tue, 9 Dec 2025 12:02:33 +0000 Subject: [PATCH 2/2] Update error message to improve clarity --- lib/GADS/View.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/GADS/View.pm b/lib/GADS/View.pm index 8cea6865c..8cdb7757c 100644 --- a/lib/GADS/View.pm +++ b/lib/GADS/View.pm @@ -340,7 +340,7 @@ sub write # Names consisting of just whitespace characters cause issues when displaying a view $self->name !~ /^\s*$/ - or error __"View name must not contain whitespace characters"; + or error __"View name must not contain only whitespace characters"; my $global = !$self->layout->user ? 1 : $self->global;