Merge pull request #50 from deploymenttheory/dev

Dev

Author: ShocOne

httpclient/httpclient_methods.go

@@ -1,13 +1,33 @@
+// httpclient_methods.go
 package httpclient
 
+/* Ref: https://www.rfc-editor.org/rfc/rfc7231#section-8.1.3
+
++---------+------+------------+
+| Method  | Safe | Idempotent |
++---------+------+------------+
+| CONNECT | no   | no         |
+| DELETE  | no   | yes        |
+| GET     | yes  | yes        |
+| HEAD    | yes  | yes        |
+| OPTIONS | yes  | yes        |
+| POST    | no   | no         |
+| PUT     | no   | yes        |
+| TRACE   | yes  | yes        |
++---------+------+------------+
+*/
+
 import "net/http"
 
 // IsIdempotentHTTPMethod checks if the given HTTP method is idempotent.
 func IsIdempotentHTTPMethod(method string) bool {
 	idempotentHTTPMethods := map[string]bool{
-		http.MethodGet:    true,
-		http.MethodPut:    true,
-		http.MethodDelete: true,
+		http.MethodGet:     true,
+		http.MethodPut:     true,
+		http.MethodDelete:  true,
+		http.MethodHead:    true,
+		http.MethodOptions: true,
+		http.MethodTrace:   true,
 	}
 
 	return idempotentHTTPMethods[method]
@@ -17,8 +37,9 @@ func IsIdempotentHTTPMethod(method string) bool {
 // PATCH can be idempotent but often isn't used as such.
 func IsNonIdempotentHTTPMethod(method string) bool {
 	nonIdempotentHTTPMethods := map[string]bool{
-		http.MethodPost:  true,
-		http.MethodPatch: true,
+		http.MethodPost:    true,
+		http.MethodPatch:   true,
+		http.MethodConnect: true,
 	}
 
 	return nonIdempotentHTTPMethods[method]