Skip to content

Styleguide CSS has a CSS reset and modifies <body> #37

@paulkoegel

Description

@paulkoegel

see https://github.com/devnacho/mountain_view/blob/master/app/assets/stylesheets/mountain_view/styleguide.css#L10
and https://github.com/devnacho/mountain_view/blob/master/app/assets/stylesheets/mountain_view/styleguide.css#L8

<body> is not really an issue, but i think the styleguide generated by mountain view should use the same unmodified styles as the app - hence everything in the styleguide's CSS (which styles the styleguides navigation bar and meta information) should be encapsulated in classes that are unlikely to clash with anything from my app. one could debate whether the current naming convention for styleguide elements using mv-... is safe enough.

the CSS reset is especially problematic since it targets plain HTML tags. unless i'm using the same reset (Eric Meyer's v 2) in my app, i might get different looking elements in the styleguide than in the app.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions